Skip to content

Conversation

@Rageking8
Copy link
Contributor

@Rageking8 Rageking8 commented Mar 7, 2025

Summary:

  • Fix missing period and semicolon
  • Fix broken link to #allocator_type
  • Fix broken comment on vector_assign.cpp
  • Improve examples
    • Normalize all formatting (4 space indents, no excessive space around parentheses and angle brackets, template and brace on a new line, and others)
    • Remove dead code and superfluous includes
    • Add missing Output code block where appropriate
    • Test all examples to check that they compile and that the Output part is correct

@prmerger-automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 70ce14a:

✅ Validation status: passed

File Status Preview URL Details
docs/standard-library/vector-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@prmerger-automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@ttorble
Copy link
Contributor

ttorble commented Mar 7, 2025

@TylerMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Mar 7, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better. Thanks for fixing typos and I particularly appreciate you adding the output sections! Your work is very much appreciated!

@TylerMSFT
Copy link
Collaborator

#sign-off

@v-dirichards v-dirichards merged commit 497bf3c into MicrosoftDocs:main Mar 7, 2025
2 checks passed
@Rageking8 Rageking8 deleted the updates-for-vector-class-template-reference branch March 9, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants