Structure error references in range [C3421, C3480] #5681
Conversation
|
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
PRMerger Results
|
| > 'type' : you can only forward a type to an assembly: | ||
| ## Remarks | ||
|
|
||
| '`file`' is not an assembly |
There was a problem hiding this comment.
Not sure if these 2 lines are supposed to be 1 as depicted here:
For now, I just applied the usual changes here. A future PR could fix this after a bit of research to confirm the error message.
There was a problem hiding this comment.
Hi @Rageking8, it's two lines. Here's example output from the compiler:
C3468_b.cpp(4): error C3468: 'R': you can only forward a type to an assembly:
'test\C3468.netmodule' is not an assembly
There was a problem hiding this comment.
That's interesting, this is the first multi line error message I came across. I presume we would preserve the newline and make the blockquote 2 lines long. However, that presentation is being used by error messages that have multiple "forms".
There was a problem hiding this comment.
I think it's less confusing to put it all on one line.
That won't present an obstacle to someone who reads it and may reduce confusion for the person who is aware of our multiple lines means multiple forms format.
There was a problem hiding this comment.
Since the diff is small, I added the commit in this PR for convenience. The error message is edited to match:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
|
Learn Build status updates of commit f1f16e2: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
|
#sign-off |
3 participants
This is batch 58 that structures error/warning references. See #5465 for more information.