Skip to content

Break up Release Notes into 3 pages: About, latest 5 months, & Archived#3106

Merged
captainbrosset merged 28 commits intomainfrom
user/mikehoffms/relnotes-pages
Mar 21, 2024
Merged

Break up Release Notes into 3 pages: About, latest 5 months, & Archived#3106
captainbrosset merged 28 commits intomainfrom
user/mikehoffms/relnotes-pages

Conversation

@mikehoffms
Copy link
Copy Markdown
Collaborator

@mikehoffms mikehoffms commented Mar 14, 2024

Rendered webpages for review:

Before/Live:

This PR also makes the following changes:

  • In the Redirects file (.openpublishing.redirection.json):
    • Added a list of sections at top.
    • Resequenced the sections of redirects per latest top-level TOC buckets.
    • Added more C++-style /* comments */
    • Added blank lines.
    • Updated the existing two redirects for RelNotes webpage.

Doc-design model followed

Compare also:


Redirects

URLs to test for equivalence to the existing live link:

"source_path": "microsoft-edge/webview2/release-notes.md",
"redirect_url": "/microsoft-edge/webview2/release-notes/index",

Announcement links will fully resolve for recent releases, partially resolve for older releases.

Learn Platform Manual > How to redirect obsolete articles
https://review.learn.microsoft.com/help/platform/redirect-articles

Spot-check of redirects

A spot-check of a redirect that got moved (when resequencing the .json file) and has a blank line above it in the .json file:

"source_path": "microsoft-edge/devtools-guide-chromium/beginners/html.md",
"redirect_url": "/microsoft-edge/devtools-guide-chromium/dom",

Old URL according to review.LMC of this PR:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/beginners/html?branch=pr-en-us-3106
After click that link, end up at URL in this review PR:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/dom/?branch=pr-en-us-3106
which is equivalent to live link:
https://learn.microsoft.com/microsoft-edge/devtools-guide-chromium/dom/

This demonstrates that the redirects file continues to work.

AB#49470884

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Mar 14, 2024
@mikehoffms mikehoffms marked this pull request as ready for review March 15, 2024 18:07
@victorhuangwq victorhuangwq requested review from ahmedalshakra and removed request for ahmedalshakra March 18, 2024 20:50
Copy link
Copy Markdown
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good in overall, some comments

Comment thread microsoft-edge/webview2/release-notes/about.md
Comment thread microsoft-edge/toc.yml
@MicrosoftDocs MicrosoftDocs deleted a comment from ahmedalshakra Mar 18, 2024
@MicrosoftDocs MicrosoftDocs deleted a comment from ahmedalshakra Mar 18, 2024
Comment thread microsoft-edge/webview2/release-notes/index.md
Comment thread microsoft-edge/webview2/release-notes/index.md Outdated
Comment thread microsoft-edge/webview2/release-notes/index.md Outdated
Copy link
Copy Markdown
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments on the new change

Comment thread microsoft-edge/webview2/release-notes/index.md Outdated
Comment thread microsoft-edge/webview2/release-notes/index.md Outdated
@learn-build-service-prod
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@captainbrosset captainbrosset merged commit 9675ffc into main Mar 21, 2024
@captainbrosset captainbrosset deleted the user/mikehoffms/relnotes-pages branch March 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat: webview2 WebView-related content.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants