Skip to content

Conversation

@mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Jan 14, 2025

Related PR: microsoft/MicrosoftEdge-Extensions#254

Testing redirects before Merge

Part 1

Implementation of "part1" redirect:

"source_path": "microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md",
"redirect_url": "/microsoft-edge/extensions-chromium/getting-started/picture-viewer-popup-webpage",

https://review.learn.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/part1-simple-extension?branch=pr-en-us-3342
Result: ok.
End up at:
https://review.learn.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/picture-viewer-popup-webpage?branch=pr-en-us-3342

Part 2

Implementation of "part2" redirect:

"source_path": "microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md",
"redirect_url": "/microsoft-edge/extensions-chromium/getting-started/picture-inserter-content-script",

https://review.learn.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts?branch=pr-en-us-3342
Result: ok.
End up at:
https://review.learn.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/picture-inserter-content-script?branch=pr-en-us-3342

Testing redirects after Merge

https://learn.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/part1-simple-extension
Result: __
End up at: __

https://learn.microsoft.com/en-us/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts
Result: __
End up at: __

AB#55806358

@mikehoffms mikehoffms marked this pull request as ready for review January 15, 2025 22:59
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of comments.

Copy link
Collaborator Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Content Developer

@learn-build-service-prod
Copy link

Learn Build status updates of commit ed74825:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
microsoft-edge/developer/index.yml ✅Succeeded View
microsoft-edge/devtools-guide-chromium/sources/index.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/sidebar.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/developermode-toggle.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extension-running.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-popup-no-extensions.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-popup.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/installed-extension.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-developermode-toggle.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-installed-extension.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/settings-and-more-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/index.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/clone-a-repo-dbox-ghd.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/developermode-toggle.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extension-running.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-popup-no-extensions.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-popup-with-launch-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extensions-popup.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/icon-png-toolbar.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/load-unpacked-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/part1-installed-extension.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit be48140 into main Jan 29, 2025
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/redesign-samples branch January 29, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat: extensions Extensions-related content.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants