Skip to content

Globally say "Microsoft Edge Add-ons", without "store", "site", or "website"#3409

Merged
captainbrosset merged 11 commits intomainfrom
bhuvanapriyap-patch-3
Mar 24, 2025
Merged

Globally say "Microsoft Edge Add-ons", without "store", "site", or "website"#3409
captainbrosset merged 11 commits intomainfrom
bhuvanapriyap-patch-3

Conversation

@bhuvanapriyap
Copy link
Copy Markdown
Contributor

@bhuvanapriyap bhuvanapriyap commented Mar 19, 2025

You develop a Microsoft Edge extension, and then publish the extension at Microsoft Edge Add-ons.

Rendered article sections for review:

Testing the redirect before merging:

Impl:

"source_path": "./microsoft-edge/extensions-chromium/publish/add-ons-store-curation.md",
"redirect_url": "/microsoft-edge/extensions-chromium/publish/add-ons-curation",

https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/publish/add-ons-store-curation?branch=pr-en-us-3409
Expect to end up at url similar to:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/publish/add-ons-curation?branch=pr-en-us-3409
Status: __
Ended up at: __

Testing the redirect after merging:

https://learn.microsoft.com/microsoft-edge/extensions-chromium/publish/add-ons-store-curation
Expect to end up at url similar to:
https://learn.microsoft.com/microsoft-edge/extensions-chromium/publish/add-ons-curation
Status: __
Ended up at: __

AB#56766281

@bhuvanapriyap bhuvanapriyap marked this pull request as ready for review March 19, 2025 09:23
Comment thread microsoft-edge/extensions-chromium/getting-started/extension-sideloading.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-store-curation.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/create-dev-account.md
Comment thread microsoft-edge/extensions-chromium/developer-guide/best-practices.md Outdated
@mikehoffms mikehoffms changed the title Update best-practices.md Reword from "Add-ons store" Mar 19, 2025
@mikehoffms mikehoffms added the cat: extensions Extensions-related content. label Mar 19, 2025
Comment thread microsoft-edge/extensions-chromium/developer-guide/best-practices.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-store-curation.md Outdated
@mikehoffms mikehoffms changed the title Reword from "Add-ons store" Globally say "the Microsoft Edge Add-ons site" instead of "store" or "website" Mar 19, 2025
Copy link
Copy Markdown
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Writer/Editor

Comment thread microsoft-edge/extensions-chromium/publish/contact-extensions-team.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/publish-extension.md Outdated
Comment thread microsoft-edge/extensions-chromium/whats-new/released-features.md Outdated
@mikehoffms mikehoffms changed the title Globally say "the Microsoft Edge Add-ons site" instead of "store" or "website" Globally say "Microsoft Edge Add-ons", without "store", "site", or "website" Mar 20, 2025
Copy link
Copy Markdown
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now a very clear distinction between when we use "extension" and when we use "add-ons". Thank you.

I left a few comments in the diff.

I also have a general comment that applies to many files: some articles now have many links to Microsoft Edge Add-ons. I know that consistently formatting all occurrences of this helps with maintainability, but having too many links within one article, or even one section may hurt readability by attracting too much attention to the same string over and over again.

I would almost suggest a rule like this: If Microsoft Edge Add-ons appears more than once in a single section (h2, h4, or h6), only link the first instance.

The first one would therefore be: at [Microsoft Edge Add-ons](https://microsoftedge.microsoft.com/addons), and subsequent ones would be at Microsoft Edge Add-ons.

Comment thread microsoft-edge/extensions-chromium/index.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-curation.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-curation.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-curation.md
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-curation.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-curation.md Outdated
Comment thread microsoft-edge/extensions-chromium/publish/add-ons-curation.md Outdated
@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit dcb2d5b:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/extensions-chromium/developer-guide/native-messaging.md 💡Suggestion View Details
.openpublishing.redirection.json ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/extensions.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2023/08/devtools-116.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/alternate-distribution-options.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/api-support.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/best-practices.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/csp.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/declare-permissions.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/manifest-v3.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/match-patterns.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/migrate-your-extension-from-manifest-v2-to-v3.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/port-chrome-extension.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/run-compiled-code.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/picture-inserter-content-script.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/picture-viewer-popup-webpage.md ✅Succeeded View
microsoft-edge/extensions-chromium/index.md ✅Succeeded View
microsoft-edge/extensions-chromium/landing/index.yml ✅Succeeded View
microsoft-edge/extensions-chromium/publish/aad-account.md ✅Succeeded View
microsoft-edge/extensions-chromium/publish/add-ons-curation.md ✅Succeeded View
microsoft-edge/extensions-chromium/publish/add-ons-store-curation.md ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/publish/contact-extensions-team.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.

microsoft-edge/extensions-chromium/developer-guide/native-messaging.md

  • Line 233, Column 3: [Suggestion: other-site-link-broken - See documentation] Link 'https://chromium.googlesource.com/chromium/src/+/HEAD/docs/user_data_dir.md' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 253, Column 3: [Suggestion: other-site-link-broken - See documentation] Link 'https://chromium.googlesource.com/chromium/src/+/HEAD/docs/user_data_dir.md' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Comment thread microsoft-edge/extensions-chromium/index.md
@bhuvanapriyap
Copy link
Copy Markdown
Contributor Author

Approved - LGTM-PM

@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 6677039:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/extensions-chromium/developer-guide/native-messaging.md 💡Suggestion View Details
.openpublishing.redirection.json ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/extensions.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2023/08/devtools-116.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/alternate-distribution-options.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/api-support.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/best-practices.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/csp.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/declare-permissions.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/manifest-v3.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/match-patterns.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/migrate-your-extension-from-manifest-v2-to-v3.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/port-chrome-extension.md ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/run-compiled-code.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/picture-inserter-content-script.md ✅Succeeded View
microsoft-edge/extensions-chromium/getting-started/picture-viewer-popup-webpage.md ✅Succeeded View
microsoft-edge/extensions-chromium/index.md ✅Succeeded View
microsoft-edge/extensions-chromium/landing/index.yml ✅Succeeded View
microsoft-edge/extensions-chromium/publish/aad-account.md ✅Succeeded View
microsoft-edge/extensions-chromium/publish/add-ons-curation.md ✅Succeeded View
microsoft-edge/extensions-chromium/publish/add-ons-store-curation.md ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/publish/contact-extensions-team.md ✅Succeeded View

This comment lists only the first 25 files in the pull request.

microsoft-edge/extensions-chromium/developer-guide/native-messaging.md

  • Line 233, Column 3: [Suggestion: other-site-link-broken - See documentation] Link 'https://chromium.googlesource.com/chromium/src/+/HEAD/docs/user_data_dir.md' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 253, Column 3: [Suggestion: other-site-link-broken - See documentation] Link 'https://chromium.googlesource.com/chromium/src/+/HEAD/docs/user_data_dir.md' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@captainbrosset captainbrosset merged commit 0dcf5ad into main Mar 24, 2025
2 checks passed
@captainbrosset captainbrosset deleted the bhuvanapriyap-patch-3 branch March 24, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat: extensions Extensions-related content.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants