Skip to content

Conversation

@localden
Copy link
Collaborator

@localden localden commented Jul 6, 2023

This pull request maximize the developer context and minimizes the time they need to spend figuring things out.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

Co-authored-by: Ray Luo <rayluo.mba@gmail.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit ff71a81:

⚠️ Validation status: warnings

File Status Preview URL Details
msal-python-conceptual/getting-started/call-protected-web-api.md ⚠️Warning n/a (file deleted or renamed) Details
msal-python-conceptual/getting-started/why-use-msal-python.md ⚠️Warning n/a (file deleted or renamed) Details
msal-python-conceptual/advanced/wam.md ✅Succeeded View
msal-python-conceptual/docfx.json ✅Succeeded
msal-python-conceptual/getting-started/acquiring-tokens.md ✅Succeeded View
msal-python-conceptual/getting-started/client-applications.md ✅Succeeded View
msal-python-conceptual/index.md ✅Succeeded View
msal-python-conceptual/media/basic-pca-app-prompt.gif ✅Succeeded View
msal-python-conceptual/media/redirect-urls.png ✅Succeeded View
msal-python-conceptual/media/wam-common.png ✅Succeeded View
msal-python-conceptual/media/wam-consumers.png ✅Succeeded View
msal-python-conceptual/media/wam-organizations.png ✅Succeeded View
msal-python-conceptual/media/wam-python.gif ✅Succeeded View
msal-python-conceptual/media/wam-tenant-specific.png ✅Succeeded View
msal-python-conceptual/TOC.yml ✅Succeeded View
python/docfx.json ✅Succeeded

msal-python-conceptual/getting-started/call-protected-web-api.md

  • [Warning: file-not-redirected - See documentation] File msal-python-conceptual/getting-started/call-protected-web-api.md with URL /entra/msal/python/getting-started/call-protected-web-api was deleted without redirection. To avoid broken links, add a redirection.

msal-python-conceptual/getting-started/why-use-msal-python.md

  • [Warning: file-not-redirected - See documentation] File msal-python-conceptual/getting-started/why-use-msal-python.md with URL /entra/msal/python/getting-started/why-use-msal-python was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments above. Overall LGTM.

@learn-build-service-prod
Copy link

Learn Build status updates of commit c38b79d:

⚠️ Validation status: warnings

File Status Preview URL Details
msal-python-conceptual/getting-started/call-protected-web-api.md ⚠️Warning n/a (file deleted or renamed) Details
msal-python-conceptual/getting-started/why-use-msal-python.md ⚠️Warning n/a (file deleted or renamed) Details
msal-python-conceptual/advanced/wam.md ✅Succeeded View
msal-python-conceptual/docfx.json ✅Succeeded
msal-python-conceptual/getting-started/acquiring-tokens.md ✅Succeeded View
msal-python-conceptual/getting-started/client-applications.md ✅Succeeded View
msal-python-conceptual/index.md ✅Succeeded View
msal-python-conceptual/media/basic-pca-app-prompt.gif ✅Succeeded View
msal-python-conceptual/media/redirect-urls.png ✅Succeeded View
msal-python-conceptual/media/wam-common.png ✅Succeeded View
msal-python-conceptual/media/wam-consumers.png ✅Succeeded View
msal-python-conceptual/media/wam-organizations.png ✅Succeeded View
msal-python-conceptual/media/wam-python.gif ✅Succeeded View
msal-python-conceptual/media/wam-tenant-specific.png ✅Succeeded View
msal-python-conceptual/TOC.yml ✅Succeeded View
python/docfx.json ✅Succeeded

msal-python-conceptual/getting-started/call-protected-web-api.md

  • [Warning: file-not-redirected - See documentation] File msal-python-conceptual/getting-started/call-protected-web-api.md with URL /entra/msal/python/getting-started/call-protected-web-api was deleted without redirection. To avoid broken links, add a redirection.

msal-python-conceptual/getting-started/why-use-msal-python.md

  • [Warning: file-not-redirected - See documentation] File msal-python-conceptual/getting-started/why-use-msal-python.md with URL /entra/msal/python/getting-started/why-use-msal-python was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@localden localden merged commit ba4b33e into main Jul 7, 2023
@localden localden deleted the docs-contrib branch July 7, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants