Skip to content

Conversation

@localden
Copy link
Collaborator

@localden localden commented Sep 6, 2024

No description provided.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3f4fc22:

⚠️ Validation status: warnings

File Status Preview URL Details
msal-python-conceptual/docfx.json ⚠️Warning Details
msal-python-conceptual/advanced/macos-broker.md ✅Succeeded View
msal-python-conceptual/advanced/wam.md ✅Succeeded View
msal-python-conceptual/TOC.yml ✅Succeeded View

msal-python-conceptual/docfx.json

  • Line 47, Column 33: [Warning: feedback-system-invalid - See documentation] Invalid value for 'feedback_system': 'GitHub'. The value for "feedback_system" must be either "Standard", "OpenSource" or "None".

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Comment on lines +47 to +51
For signed applications, the redirect URI should be:

```text
msauth.BUNDLE_ID://auth
```
Copy link
Collaborator

@rayluo rayluo Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengga mentioned it offline that a Python script might not be able to have bundle id at all. If so, then this "for signed applications" paragraph is not applicable to be put in this "MSAL Python Conceptual" document.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengga @rayluo can it ever be signed? What about GUI apps?

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3325c9f:

⚠️ Validation status: warnings

File Status Preview URL Details
msal-python-conceptual/docfx.json ⚠️Warning Details
msal-python-conceptual/advanced/macos-broker.md ✅Succeeded View
msal-python-conceptual/advanced/wam.md ✅Succeeded View
msal-python-conceptual/TOC.yml ✅Succeeded View

msal-python-conceptual/docfx.json

  • Line 47, Column 33: [Warning: feedback-system-invalid - See documentation] Invalid value for 'feedback_system': 'GitHub'. The value for "feedback_system" must be either "Standard", "OpenSource" or "None".

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit f7a744b:

⚠️ Validation status: warnings

File Status Preview URL Details
msal-python-conceptual/docfx.json ⚠️Warning Details
msal-python-conceptual/advanced/macos-broker.md ✅Succeeded View
msal-python-conceptual/advanced/wam.md ✅Succeeded View
msal-python-conceptual/TOC.yml ✅Succeeded View

msal-python-conceptual/docfx.json

  • Line 47, Column 33: [Warning: feedback-system-invalid - See documentation] Invalid value for 'feedback_system': 'GitHub'. The value for "feedback_system" must be either "Standard", "OpenSource" or "None".

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 2dd168f:

✅ Validation status: passed

File Status Preview URL Details
msal-python-conceptual/advanced/macos-broker.md ✅Succeeded View
msal-python-conceptual/advanced/wam.md ✅Succeeded View
msal-python-conceptual/docfx.json ✅Succeeded
msal-python-conceptual/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 6f73a4a:

✅ Validation status: passed

File Status Preview URL Details
msal-python-conceptual/advanced/macos-broker.md ✅Succeeded View
msal-python-conceptual/advanced/wam.md ✅Succeeded View
msal-python-conceptual/docfx.json ✅Succeeded
msal-python-conceptual/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@rayluo rayluo merged commit b3f2aac into main Sep 12, 2024
@rayluo rayluo deleted the macos-broker branch September 12, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants