Skip to content

Linkchecker fail issue on live publish#249

Merged
Dickson-Mwendia merged 4 commits into
livefrom
main
May 19, 2026
Merged

Linkchecker fail issue on live publish#249
Dickson-Mwendia merged 4 commits into
livefrom
main

Conversation

@Dickson-Mwendia
Copy link
Copy Markdown
Collaborator

No description provided.

Dickson-Mwendia and others added 2 commits May 19, 2026 10:41
The linkchecker workflow was missing a pull_request trigger, so it never
ran as a PR check. This adds the trigger so broken links are caught
before merging. Also excludes the live branch from push triggers since
links are already validated on main.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add pull_request trigger to linkchecker workflow
@Dickson-Mwendia Dickson-Mwendia requested a review from jmprieur as a code owner May 19, 2026 07:45
@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 409790b:

✅ Validation status: passed

File Status Preview URL Details
.github/workflows/linkchecker.yml ✅Succeeded

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

Dickson-Mwendia and others added 2 commits May 19, 2026 11:00
- Add .lychee.toml so lychee doesn't mistakenly parse package.json as config
- Pass --config=.lychee.toml explicitly in workflow args
- Remove pull_request trigger (push trigger already covers PR branches)
- Exclude live branch from push triggers (already validated on main)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix linkchecker: add config file and exclude live branch
@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit add169c:

✅ Validation status: passed

File Status Preview URL Details
.github/workflows/linkchecker.yml ✅Succeeded
.lychee.toml ✅Succeeded

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@Dickson-Mwendia Dickson-Mwendia merged commit 35ab2ad into live May 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant