-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix syntax for ALTER INDEX REBUILD options in documentation #10257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current syntax description does not allow specifying index rebuild options without including a PARTITION clause. Both the examples on this page and elsewhere and actual testing in SQL Server 2022 show that the proposed syntax works and is actually supported.
|
@FladoToo : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 269f2ce: ✅ Validation status: passed
For more details, please refer to the build report. |
|
@FladoToo thanks for finding this problem. Please also change the curly brackets after |
Implementing the change suggested by the reviewer @dimitri-furman
|
Learn Build status updates of commit 7d80833: ✅ Validation status: passed
For more details, please refer to the build report. |
Updated the review team and modified the date.
|
Thanks @FladoToo for taking the time to submit this PR! Good catch. After you confirm the CLA, your commit will be merged and this article update is in flight. After the updated article is published, GitHub will list you as an article contributor. Thanks again for this feedback, your suggestions help improve our documentation. |
|
Learn Build status updates of commit 1e3d5b6: ✅ Validation status: passed
For more details, please refer to the build report. |
|
#label:"aq-pr-triaged" |
|
I did this in the course of a contract so it is my customer who owns any IP. However, I have no right to agree to the CLA on their behalf yet - I asked them for authorization, and will get back to you when I hear from them. Sorry, I didn't think it would be that complicated. |
|
@FladoToo I understand, in this case, the "code" is limited to the TSQL syntax in this PR, and not any other code. This is a blanket requirement for public contributions to Microsoft Open Source docs that prevents us from inadvertently publishing owned content. I think you're good to go here. |
|
This has conflicted with an internal PR. I'm going to take this commit internally and resolve internally. Your commit will be merged and this article update is in flight. After the updated article is published, GitHub will list you as an article contributor. #please-close |
The current syntax description does not allow specifying index rebuild options without including a PARTITION clause. Both the examples on this page (e.g.
ALTER INDEX IX_INDEX1 ON T1 REBUILD WITH (DATA_COMPRESSION = PAGE); GO) and elsewhere, and actual testing in SQL Server 2022 show that the proposed syntax works and is actually supported.