-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[PowerToys Awake] Clarify lock screen behavior, add security considerations #5719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added information about lock screen behavior and its impact on PowerToys Awake functionality. Added specific notes about security considerations from using Awake instead of customizing a Power Plan (as Awake cannot be used while the device is locked).
|
@daverayment : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 1a4f950: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding more clarification around Awake's behavior. I added some minor wording suggestions based on our style guide recommendations.
|
I'm going to go ahead and commit my suggestions so we can get this PR merged today and have it published tonight with our nightly publish job. |
Style guide related changes.
|
Learn Build status updates of commit 67eb3ef: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Thank you, Alvin. |
…8734317696sync_temp For protected branch, push strategy should use PR and merge to target branch method to work around git push error
Added information about lock screen behavior and its impact on PowerToys Awake functionality. Added specific notes about security considerations from using Awake instead of customizing a Power Plan (as Awake cannot be used while the device is locked).
Created in response to this issue from the PowerToys repo: microsoft/PowerToys#42069