Skip to content

Conversation

@Malind19
Copy link
Contributor

No description provided.

@Malind19 Malind19 mentioned this pull request Apr 28, 2019
@o0nj
Copy link
Contributor

o0nj commented Apr 29, 2019

@nenonix Minor Copy editing is needed for this PR. Thanks.

Copy link
Contributor

@nenonix nenonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy review

Co-Authored-By: Malind19 <malindesilva@live.com>
@Malind19
Copy link
Contributor Author

Malind19 commented May 2, 2019

@e0i Copy edits applied

@o0nj
Copy link
Contributor

o0nj commented May 9, 2019

Issue reference: #546

@o0nj
Copy link
Contributor

o0nj commented May 17, 2019

@dariomws306 @get-itips @tseward

Please review the final formatting changes as revised by the PR author.

(Last PR in fourth package)

@get-itips
Copy link
Contributor

Something is not right with the live version of this article, which is, based on the folders in the repo, the Windows Server 2012 one.

If you go to https://docs.microsoft.com/en-us/powershell/module/addsadministration/get-addomaincontroller?view=win10-ps you get the WinServ2016 version of this cmdlet.

If you want to change it to Windows Server 2012 using the version selector, you will receive a message like this: The requested page is not available for Windows Server 2012 PowerShell. You have been redirected to the newest product version this page is available for.

If you edit that page, you are not editing the one that is under the folder docset/winserver2012-ps/activedirectory but /docset/windows/addsadministration/

So I think, besides the markdown is in the repo, it isn't published or accesible through Docs.

Maybe we need to fix that before.

Talking specifically about the document, It does not seem well formatted:

image

but I think these "description" were present before @Malind19 commits

@dariomws
Copy link
Contributor

Agree with @get-itips!

@o0nj
Copy link
Contributor

o0nj commented May 20, 2019

@tseward Any additional comments?

@ghost
Copy link

ghost commented May 22, 2019

I'm good with the change but if we could get the Descriptions cleaned up as @get-itips notes, that would be great.

@o0nj
Copy link
Contributor

o0nj commented May 22, 2019

@Malind19 Please follow-up with suggested revisions for this PR. Thanks.

@AndreaBarr AndreaBarr merged commit aa4c2c8 into MicrosoftDocs:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants