Fix casing of windows module and cmdlet filenames
#1250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello Joey, The merges are on hold due to internal maintenance, which concerns fixing various schema errors and syncing public repository contents to live. Consulted @DaniHalfin on whether to merge this PR prior or later that maintenance since he operates the maintenance. Also passed your note regarding the moniker. Thank you for taking the initiative to improve PowerShell documentation writing experience. |
Author
|
Yeah, I'm internal (I'm the PM owner of PowerShell itself) and on a thread with @DaniHalfin. Feel free to follow-up offline. |
Contributor
|
Saw the internal thread. Will merge as soon as possible. |
Contributor
|
Pending @DaniHalfin's input. |
Contributor
|
cc @DaniHalfin |
Contributor
|
@joeyaiello The maintenance of the deployment system has been completed and certain changes post-maintenance has caused merge conflicts. Would you be able to resolve the conflicts so that we proceed with merge? Thanks. cc @DaniHalfin |
Author
|
Should be rebased now |
|
Docs Build status updates of commit ddf4fe5:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docset/windows/toc.yml | Details | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Disable-DiagnosticDataViewing.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Enable-DiagnosticDataViewing.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticData.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticDataTypes.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticDataViewingSetting.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticStoreCapacity.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Microsoft.DiagnosticsDataViewer.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Set-DiagnosticStoreCapacity.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Disable-ServerManagerStandardUserRemoting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Enable-ServerManagerStandardUserRemoting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Export-SmigServerSetting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Get-SmigServerFeature.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Get-WindowsFeature.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Import-SmigServerSetting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Install-WindowsFeature.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Receive-SmigServerData.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Send-SmigServerData.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/ServerManager.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Uninstall-WindowsFeature.md | ✅Succeeded | ||
| docset/windows/adcsadministration/ADCSAdministration.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Add-CAAuthorityInformationAccess.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Add-CACrlDistributionPoint.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Add-CATemplate.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Backup-CARoleService.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Confirm-CAEndorsementKeyInfo.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Get-CAAuthorityInformationAccess.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Get-CACrlDistributionPoint.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Get-CATemplate.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Remove-CAAuthorityInformationAccess.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Remove-CACrlDistributionPoint.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Remove-CATemplate.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Restore-CARoleService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/ADCSDeployment.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsCertificationAuthority.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsEnrollmentPolicyWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsEnrollmentWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsNetworkDeviceEnrollmentService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsOnlineResponder.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsWebEnrollment.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsCertificationAuthority.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsEnrollmentPolicyWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsEnrollmentWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsNetworkDeviceEnrollmentService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsOnlineResponder.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsWebEnrollment.md | ✅Succeeded | ||
| docset/windows/addsadministration/ActiveDirectory.md | ✅Succeeded | ||
| docset/windows/addsadministration/Add-ADCentralAccessPolicyMember.md | ✅Succeeded | ||
| docset/windows/addsadministration/Add-ADComputerServiceAccount.md | ✅Succeeded | ||
| docset/windows/addsadministration/Add-ADDomainControllerPasswordReplicationPolicy.md | ✅Succeeded |
This comment lists only the first 50 files in the pull request.
docset/windows/toc.yml
- [Warning]
TOC item (Href:adfs/.md ) with empty name found. Missing a name? - [Warning]
TOC item (Href:adfs/.md ) with empty name found. Missing a name? - Line 0: [Warning]
Invalid file link:(~/windows/adfs/.md). - Line 0: [Warning]
Invalid file link:(~/windows/adfs/.md).
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
o0nj
added
the
Sign off
Contributor
cc @DaniHalfin |
rjagiewich
added
In review
Author
|
Rebased to fix another conflict |
|
Docs Build status updates of commit f7f9a09:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docset/windows/toc.yml | Details | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Disable-DiagnosticDataViewing.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Enable-DiagnosticDataViewing.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticData.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticDataTypes.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticDataViewingSetting.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Get-DiagnosticStoreCapacity.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Microsoft.DiagnosticsDataViewer.md | ✅Succeeded | ||
| docset/windows/Microsoft.DiagnosticDataViewer/Set-DiagnosticStoreCapacity.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Disable-ServerManagerStandardUserRemoting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Enable-ServerManagerStandardUserRemoting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Export-SmigServerSetting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Get-SmigServerFeature.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Get-WindowsFeature.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Import-SmigServerSetting.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Install-WindowsFeature.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Receive-SmigServerData.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Send-SmigServerData.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/ServerManager.md | ✅Succeeded | ||
| docset/windows/Microsoft.Windows.ServerManager.Migration/Uninstall-WindowsFeature.md | ✅Succeeded | ||
| docset/windows/adcsadministration/ADCSAdministration.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Add-CAAuthorityInformationAccess.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Add-CACrlDistributionPoint.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Add-CATemplate.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Backup-CARoleService.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Confirm-CAEndorsementKeyInfo.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Get-CAAuthorityInformationAccess.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Get-CACrlDistributionPoint.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Get-CATemplate.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Remove-CAAuthorityInformationAccess.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Remove-CACrlDistributionPoint.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Remove-CATemplate.md | ✅Succeeded | ||
| docset/windows/adcsadministration/Restore-CARoleService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/ADCSDeployment.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsCertificationAuthority.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsEnrollmentPolicyWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsEnrollmentWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsNetworkDeviceEnrollmentService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsOnlineResponder.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Install-AdcsWebEnrollment.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsCertificationAuthority.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsEnrollmentPolicyWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsEnrollmentWebService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsNetworkDeviceEnrollmentService.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsOnlineResponder.md | ✅Succeeded | ||
| docset/windows/adcsdeployment/Uninstall-AdcsWebEnrollment.md | ✅Succeeded | ||
| docset/windows/addsadministration/ActiveDirectory.md | ✅Succeeded | ||
| docset/windows/addsadministration/Add-ADCentralAccessPolicyMember.md | ✅Succeeded | ||
| docset/windows/addsadministration/Add-ADComputerServiceAccount.md | ✅Succeeded | ||
| docset/windows/addsadministration/Add-ADDomainControllerPasswordReplicationPolicy.md | ✅Succeeded |
This comment lists only the first 50 files in the pull request.
docset/windows/toc.yml
- [Warning]
TOC item (Href:adfs/.md ) with empty name found. Missing a name? - [Warning]
TOC item (Href:adfs/.md ) with empty name found. Missing a name? - Line 0: [Warning]
Invalid file link:(~/windows/adfs/.md). - Line 0: [Warning]
Invalid file link:(~/windows/adfs/.md).
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
tfosmark
added
Back to submitter
Contributor
|
@joeyaiello Please resolve the warnings in the build report and add the SignOff label when the build completes without warnings. Thanks! |
Contributor
|
@joeyaiello Would you be able to resolve build warnings on toc.yml file? We would like to proceed with merge. Thank you for your time and attention. |
|
Docs Build status updates of commit 9467781: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
tfosmark
added
Sign off
Contributor
|
Set the SignOff label per @joeyaiello. |
o0nj
added
Sign off
claydetels19
added
In review
Contributor
|
Hi @joeyaiello and @e0i - We understand that these PR criteria are new, and we appreciate your patience with the process. Following are blocking issues that need to be resolved before we can review:
Reference Criteria used for pull request reviews Blocking
thanks! -Rebecca |
rjagiewich
added
Back to submitter
|
Docs Build status updates of commit 334c10c: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this short script using PSYaml to fix the casing of each cmdlet and module name in the
windowsfolder based on thetitlefield of the YAML front matter. I had to make a couple small edits to the YAML front matter of some newer cmdlets in order to get it to work properly (those fixes are included in a smaller commit also included in this PR).This PR does not include fixes to the TOC nor to folders other than
windowswithin the docset. Those may take me a little longer, and I wanted to get this out so as to set an example for any new cmdlets or modules. I can help with both of those at some point in the future.