Skip to content

Conversation

@msbemba
Copy link
Contributor

@msbemba msbemba commented Aug 28, 2019

Added description for Smbinstance

Added description for Smbinstance
@opbld31
Copy link

opbld31 commented Aug 28, 2019

Docs Build status updates of commit 32f2afe:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012r2-ps/smbshare/Unblock-SmbShareAccess.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj
Copy link
Contributor

o0nj commented Aug 30, 2019

@tseward

Additional approval needed for this PR.

Relevant: #1260

Thanks.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the previous cmdlet, using the phrase 'Specifies the input' isn't specific enough. If I was unfamiliar with the cmdlet, I wouldn't know what "input" means.

@o0nj
Copy link
Contributor

o0nj commented Aug 31, 2019

cc @msbemba

@msbemba
Copy link
Contributor Author

msbemba commented Sep 1, 2019

Like the previous cmdlet, using the phrase 'Specifies the input' isn't specific enough. If I was unfamiliar with the cmdlet, I wouldn't know what "input" means.

I have added an example with one of the accepted value. the accepted values are mentioned so it has be either CSV or Default

Added an example for smbinstance
@opbld34
Copy link

opbld34 commented Sep 1, 2019

Docs Build status updates of commit 2d5b7e7:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012r2-ps/smbshare/Unblock-SmbShareAccess.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Added more options to the Accepted value SMB instance
@opbld30
Copy link

opbld30 commented Sep 10, 2019

Docs Build status updates of commit b48958c:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012r2-ps/smbshare/Unblock-SmbShareAccess.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 12, 2019
@rmca14 rmca14 added the In review PubOps is reviewing the pull request label Sep 13, 2019
@rmca14 rmca14 merged commit 288c9be into MicrosoftDocs:master Sep 13, 2019
@rmca14 rmca14 added Ready to Merge and removed In review PubOps is reviewing the pull request labels Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sign off The pull request is ready to be reviewed and merged by PubOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants