Skip to content

Conversation

@velkovb
Copy link
Contributor

@velkovb velkovb commented Sep 14, 2019

…iption updated.

@opbld33
Copy link

opbld33 commented Sep 14, 2019

Docs Build status updates of commit c155ba6:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/netadapter/set-netadapterencapsulatedpackettaskoffload.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj
Copy link
Contributor

o0nj commented Sep 15, 2019

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@o0nj
Copy link
Contributor

o0nj commented Sep 15, 2019

@dariomws306 @get-itips @tseward

Peer review needed for this PR. Thanks.

@dariomws
Copy link
Contributor

I think it needs more work. My findings:

  • NvgreEncapsulatedPacketTaskOffloadEnabled and VxlanEncapsulatedPacketTaskOffloadEnabled applies to 2016.
  • EncapsulatedPacketTaskOffloadEnabled applies to 2012 and 2012 R2.
  • So, examples are ok, they are for 2012 and 2012 R2.

@ghost
Copy link

ghost commented Sep 16, 2019

@dariomws306 are you indicating the examples are fine as-is or need adjustment to accommodate for 2012/2012 R2?

@dariomws
Copy link
Contributor

@tseward they are fine as-is for 2012/2012R2.

But they don't work for 2016... So I think we should leave a comment in the example description about that.

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy Review - minor change

velkovb and others added 2 commits September 16, 2019 10:05
…offload.md

Co-Authored-By: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@velkovb
Copy link
Contributor Author

velkovb commented Sep 16, 2019

@dariomws306 This is the 2016 version article. I have not changed the examples in the 2012/2012R2 ones.

@opbld34
Copy link

opbld34 commented Sep 16, 2019

Docs Build status updates of commit e1d79d9:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/netadapter/set-netadapterencapsulatedpackettaskoffload.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld31
Copy link

opbld31 commented Sep 16, 2019

Docs Build status updates of commit 7b6a643:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/netadapter/set-netadapterencapsulatedpackettaskoffload.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dariomws
Copy link
Contributor

dariomws commented Sep 16, 2019

@velkovb, it's true, my mistake. So PR looks good. Thank you!

@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 23, 2019
@rmca14 rmca14 self-assigned this Sep 23, 2019
@rmca14 rmca14 added the In review PubOps is reviewing the pull request label Sep 23, 2019
@rmca14
Copy link
Contributor

rmca14 commented Sep 23, 2019

No Acrolinx or staging link.

@rmca14 rmca14 merged commit 53a1eb9 into MicrosoftDocs:master Sep 23, 2019
@rmca14 rmca14 removed their assignment Sep 23, 2019
@rmca14 rmca14 removed the In review PubOps is reviewing the pull request label Sep 23, 2019
@velkovb velkovb deleted the EncapsulatedPacketTaskOffloadEnabled branch October 4, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sign off The pull request is ready to be reviewed and merged by PubOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants