Skip to content

Conversation

@msbemba
Copy link
Contributor

@msbemba msbemba commented Sep 18, 2019

Changed wordings on example 1

Changed wordings on example 1
@msbemba msbemba mentioned this pull request Sep 18, 2019
@opbld33
Copy link

opbld33 commented Sep 18, 2019

Docs Build status updates of commit 0635f3c:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012r2-ps/neteventpacketcapture/Add-NetEventPacketCaptureProvider.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj
Copy link
Contributor

o0nj commented Sep 21, 2019

@dariomws306 @tseward

Peer review needed for this PR. Thanks.

@dariomws
Copy link
Contributor

Hi @msbemba, please apply the same update for 2012 R2 version.

Thanks!

@ghost
Copy link

ghost commented Sep 21, 2019

Change looks good.

@o0nj
Copy link
Contributor

o0nj commented Sep 23, 2019

Hi @msbemba, please apply the same update for 2012 R2 version.

Thanks!

cc

@msbemba
Copy link
Contributor Author

msbemba commented Sep 30, 2019

Hi @msbemba, please apply the same update for 2012 R2 version.
Thanks!

cc

Both versions of the doc are updated now.

@opbld31
Copy link

opbld31 commented Sep 30, 2019

Docs Build status updates of commit cd8b4cb:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/neteventpacketcapture/add-neteventpacketcaptureprovider.md ✅Succeeded
docset/winserver2012r2-ps/neteventpacketcapture/Add-NetEventPacketCaptureProvider.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 30, 2019
@rjagiewich
Copy link
Contributor

Hi @e0i @msbemba, per the same comment we made in #1343, we have been merging with master before pushing to live. Can we get this into master first?
cc @dstrome

thanks! -Rebecca

@rjagiewich rjagiewich added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed Sign off The pull request is ready to be reviewed and merged by PubOps labels Sep 30, 2019
@dstrome
Copy link
Contributor

dstrome commented Sep 30, 2019

@e0i @msbemba - We only accept PRs to the master branch so this PR is being closed without merging. Please submit a new PR against the master branch. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants