Skip to content

Conversation

@velkovb
Copy link
Contributor

@velkovb velkovb commented Sep 27, 2019

Added description for module cmdlets and fixed links to include ./

@opbld33
Copy link

opbld33 commented Sep 27, 2019

Docs Build status updates of commit 418b7bb:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/hyper-v/Hyper-V.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj
Copy link
Contributor

o0nj commented Sep 27, 2019

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@o0nj
Copy link
Contributor

o0nj commented Sep 27, 2019

@dariomws306 @get-itips @tseward

Peer review needed for this PR. Thanks.

@get-itips
Copy link
Contributor

Hello @velkovb What is the reason behind adding the ./ ? current links on TOC file works. Thanks

@velkovb
Copy link
Contributor Author

velkovb commented Sep 27, 2019

Hello @velkovb What is the reason behind adding the ./ ? current links on TOC file works. Thanks

@get-itips Most of the other module articles follow this format and most probably this difference here is the cause that the actual descriptions are missing.

@get-itips
Copy link
Contributor

Hello @velkovb What is the reason behind adding the ./ ? current links on TOC file works. Thanks

@get-itips Most of the other module articles follow this format and most probably this difference here is the cause that the actual descriptions are missing.

ok I don't think is necessary here, what you guys think @dariomws306 @tseward

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy Review - minor edits

Co-Authored-By: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@velkovb
Copy link
Contributor Author

velkovb commented Sep 28, 2019

@get-itips when I was updating the descriptions, I actually did it via script and missing the ./ here and it being present in the other versions of the article complicated things a lot. I think we should have it for consistency with other version of the article.

@opbld33
Copy link

opbld33 commented Sep 28, 2019

Docs Build status updates of commit 2673084:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/hyper-v/Hyper-V.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link

ghost commented Sep 28, 2019

Adding ./ doesn't change anything as that just means 'current directory'. It's extra keystrokes :-)

@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Oct 4, 2019
@v-raaba v-raaba added the In review PubOps is reviewing the pull request label Oct 4, 2019
@v-raaba v-raaba merged commit 9e08c87 into MicrosoftDocs:master Oct 4, 2019
@velkovb velkovb deleted the hyper-v-desc branch October 4, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants