Skip to content

Clarify installation, fix typos, add warnings#199

Merged
lizap merged 3 commits into
MicrosoftDocs:masterfrom
riverar:patch-3
Oct 3, 2017
Merged

Clarify installation, fix typos, add warnings#199
lizap merged 3 commits into
MicrosoftDocs:masterfrom
riverar:patch-3

Conversation

@riverar

@riverar riverar commented Sep 23, 2017

Copy link
Copy Markdown
Contributor

Fixed:

  • Clarified installation language in Server Core section
  • Added warnings in each section about 60 day cert expiration
  • Fixed up all references to Honolulu to be explicit -- Project Honolulu
  • Removed warning about PowerShell auto-complete, completely irrelevant to Project Honolulu
  • Removed reference to Chrome, expanded IE to Internet Explorer in spots

Overall language is still iffy, but at least it's usable now.

Fixed:
* Clarified installation language in Server Core section
* Added warnings in each section about 60 day cert expiration
* Fixed up all references to Honolulu to be explicit -- Project Honolulu
* Removed warning about PowerShell auto-complete, completely irrelevant to Project Honolulu
* Removed reference to Chrome, expanded IE to Internet Explorer in spots

Overall language is still iffy, but at least it's usable now.
@coreyp-at-msft

Copy link
Copy Markdown
Contributor

Hi Rafael,

Sorry it's taken a while to get back to you on this. We needed to investigate some of your revisions.

We are able to merge this PR with the exception of this:

Removed warning about PowerShell auto-complete, completely irrelevant to Project Honolulu

We have had multiple customers report this issue with 100% repro.

Please replace that warning in your PR, resubmit, and then we should be good to go.

Thanks,
Corey

@riverar

riverar commented Oct 3, 2017

Copy link
Copy Markdown
Contributor Author

Hey @coreyp-at-msft, I'm sure they reproduced it but you can also run into trouble typing gibberish, trying to left-click with the right mouse button, and trying to type with the keyboard flipped on your desk.

Having warnings on a product page for general computing issues seems out of scope.

@jwwool

jwwool commented Oct 3, 2017

Copy link
Copy Markdown
Contributor

@riverar I don't think that typing the first few letter of a file name and pressing [tab] to autocomplete is equivalent to

typing gibberish, trying to left-click with the right mouse button, and trying to type with the keyboard flipped on your desk

In most cases, the .\ added by PowerShell autocomplete does not effect the outcome of the command, so I also disagree that this is a "general computing issue"

* Restored and clarified warning about msiexec use in PowerShell environment
* Added some pre tags around variables and examples
* Fixed sentence typo
@riverar

riverar commented Oct 3, 2017

Copy link
Copy Markdown
Contributor Author

I don't agree but will defer to Microsoft team guidance here. 👍

  • Re-added warning (and moved the bottom one up a bit to prevent two warnings in a row)
  • Threw in a few back ticks and fixed a typo

@lizap

lizap commented Oct 3, 2017

Copy link
Copy Markdown

I'm merging now - will pull into private repo and publish this afternoon.

@lizap lizap merged commit 87d58c2 into MicrosoftDocs:master Oct 3, 2017
@riverar

riverar commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

Hey @lizap, how are "contributors" identified on the docs site? I don't appear there. If this is purely for employees, what's the point of showing them?

eross-msft pushed a commit that referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants