Add missing unit specification to PdfPage.Size property documentation#2500
Merged
alvinashcraft merged 4 commits intodocsfrom Aug 5, 2025
Merged
Add missing unit specification to PdfPage.Size property documentation#2500alvinashcraft merged 4 commits intodocsfrom
alvinashcraft merged 4 commits intodocsfrom
Conversation
prmerger-automator
Bot
added
the
do-not-merge
Co-authored-by: alvinashcraft <73072+alvinashcraft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Unit of size is missing
Add missing unit specification to PdfPage.Size property documentation
Aug 5, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the documentation clarity for the PdfPage.Size property by adding missing unit specification. The change addresses an issue where developers couldn't determine what units the size values represent.
- Added "in device-independent pixels (DIPs) for height and width" to the description
- Maintains consistency with related properties in the Windows.Data.Pdf namespace
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alvinashcraft
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for
PdfPage.Sizeproperty was missing the unit specification, which made it unclear what units the size values represent. This property returns aWindows.Foundation.Sizeobject containing width and height values, but the documentation didn't specify that these are measured in device-independent pixels (DIPs).Updated the description to clarify that the size is returned "in device-independent pixels (DIPs)", making it consistent with related properties in the same namespace like
PdfPageRenderOptions.DestinationHeightandPdfPageRenderOptions.DestinationWidth, which already specify their units as DIPs.The change is minimal and follows the established documentation pattern within the Windows.Data.Pdf namespace.
Fixes #2122.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.