Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #159 +/- ##
========================================
Coverage 75.32% 75.32%
========================================
Files 13 13
Lines 4016 4016
========================================
Hits 3025 3025
Misses 991 991 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StokesMIDE
requested changes
May 19, 2025
Member
StokesMIDE
left a comment
StokesMIDE
left a comment
There was a problem hiding this comment.
You can remove Python 3.8 (it reached EOL in Q3 2024). 3.13 should also be added to the list of classifiers in setup.py
pscheidler
commented
May 20, 2025
StokesMIDE
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removing 3.8