Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
===========================================
+ Coverage 75.84% 75.88% +0.03%
===========================================
Files 15 15
Lines 4450 4453 +3
===========================================
+ Hits 3375 3379 +4
+ Misses 1075 1074 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pscheidler
left a comment
There was a problem hiding this comment.
I'm sure you've tested this so it will help the Iocene folks, so I don't want to get in the way, but a few things seem odd to me:
- Are you comfortable with timeScalar and how timestamps are stored? Instead of adding in
rowTimeScalarcould you just usetimeScalar? Or have the caller use it? - It seems like now, if we store using the UTC time we convert timestamps to microseconds, but I guess we store in seconds if it is not UTC? It seems like a footgun
- Test coverage for this looks light, any thoughts?
This is eldrich code, and I'm sure we'll all be happier when it is buried. Near term, I don't think we need anything more than documentation and maybe jira tickets.
| rowTimeScalar = 1e-06 | ||
| timeScalar = 1 | ||
| else: | ||
| rowTimeScalar = 1 |
There was a problem hiding this comment.
Shouldn't rowTimeScalar still be 1e-6? Our timestamps are all still in microseconds, right? We just want to start the time from 0
The ways
Other way around... the timestamps are typically microseconds; epoch time is seconds, so the timestamps are scaled to seconds. It seemed weirder to use a nonstandard epoch and units.
It is. The tests are kind of a mess, simultaneously over-engineered and brittle. That much isn't entirely my fault, at least.
I've noted elsewhere that the export code is kind of crap. The CSV export is ancient, and the MAT code was meant to be a temporary hack. |
Fixes time scaling issue when exporting with UTC timestamps. Also updated the annotations and docstrings of the export functions/methods edited, plus some cleanup.