Conversation
Add new dependency to pom (spring-boot-starter-data-jpa) for using JPA annotations.
BREAKING CHANGE: AFD.codINEP is now an Integer (previous long).
- Add getters for new fields; - remove field codPais (not needed);
- New inner class AFDKey with all primary keys for AFD; - Add new fields to AFD (required for composite primary key);
- Fixed property name (efd --> ied); - Added setters that allow method chaining;
feat: add entity HomeDadosResponse
- Fixed typos; - Added static field to hold the response's resource type.
feat: add entity PainelEscolaResponse
feat: add HomeEscolaResponse
- Add new field ano (primary key); - Remove @id from tipo; - Update AFD.AFDKey to match;
- Replaced @JsonUnwrapped to @JsonAnyGetter.
- MeanUtils.meanAFD(...); - MeanUtils.meanIED(...);
Refactor: entidades de Domínio
feat: add MeanUtils
refactor: use MeanUtils in Home.
fix: add permission to make request
feat: add entity IDEB
feat: update HomeEscolaResponse
feat: constructors domain
feat: adiciona testes unitários para a Home.
Collaborator
Author
|
Testes unitários passaram. Já podemos dar o merge, vou só aguardar a confirmação de vocês. |
Collaborator
Author
|
Caso alguém for dar merge, lembrar de adicionar o número da versão na última linha do commit! As releases automáticas buscam um versionamento na última linha para confirmar a criação da imagem pro Docker e para criação dos arquivos necessários :) |
Contributor
|
Por mim sem problemas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podemos liberar a primeira versão pro front já ter como testar e possivelmente encontrar alguns erros também. Atualmente, já temos o controlador dos dados nacionais pronto (faltando apenas os dados do Ideb, que serão utilizados quando tivermos o BD pronto).
Já foram adicionas as correções do CORS (#35) e outras correções menores. O controlador já consegue lidar com dados faltantes (colocamos os valores para
null).O quê vocês acham?
@Arthursca
@mrjohnnus
@LuizMFL
@lucas-lins