[PATCH]_place_cursor_after_inserted_chars

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/319
Reporter	vit_r (vit_r@….ru)

Note

Original attachments:

• place_curs.gz (raw) by vit_r (vit_r@….ru) on Mar 27, 2009 at 15:35 UTC
• place_curs.patch (raw) by angel_il (@ilia-maslakov) on Mar 27, 2009 at 18:20 UTC
• place_curs2.diff (raw) by vit_r (vit_r@….ru) on Mar 29, 2009 at 16:34 UTC
• flow_insert_col.diff (raw) by vit_r (vit_r@….ru) on Mar 31, 2009 at 4:42 UTC
• 0001-flow-column-insertion.patch (raw) by vit_r (vit_r@….ru) on Apr 7, 2009 at 18:59 UTC
• 319-flow-column-insertion.patch (raw) by vit_r (vit_r@….ru) on Nov 3, 2009 at 18:06 UTC

[mc-butler]

Changed by vit_r (vit_r@….ru) on Mar 27, 2009 at 15:35 UTC

• Attachment place_curs.gz (raw) added

[mc-butler]

Changed by vit_r (vit_r@….ru) on Mar 27, 2009 at 15:46 UTC (comment 1)

• Summary changed from 319_[PATCH]_place_cursor_after_inserted_chars to [PATCH]_place_cursor_after_inserted_chars

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 27, 2009 at 16:01 UTC (comment 1.2)

Could you attach uncompressed patches? It will allow us to view them on-line.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 27, 2009 at 18:20 UTC

• Attachment place_curs.patch (raw) added

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 29, 2009 at 8:23 UTC (comment 3)

• Keywords changed from review to rework

branch: 319_cursor_after_pasted
based on: master

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 29, 2009 at 8:27 UTC (comment 4)

for test:
select text trought F3 with arrows.
move cursor another position.
press F5.
Text inserted but cursor not after pasted text.

Please rework.

[mc-butler]

Changed by ossi (@ossilator) on Mar 29, 2009 at 8:54 UTC (comment 5)

• Type changed from defect to enhancement

i'm not positive about the idea as such.
most editors advance the cursor when pasting, and it generally makes sense. however, i often find mcedit's non-advancing behavior advantageous as well.

kate/kdevelop solve this problem by overloading the vertical block selection mode switch with also doing non-advancing insertions. obviously, this is not applicable to mcedit, as no vertical selection mode is planned, only vertical selection actions.

the new qt creator ide has a different approach: insertions do advance the cursor, but if you change the line afterwards without doing something else in between, the column is reset to the pre-insertion one - you get optimal behavior for both "flowed" and "blocked" operations.

[mc-butler]

Changed by vit_r (vit_r@….ru) on Mar 29, 2009 at 16:34 UTC

• Attachment place_curs2.diff (raw) added

my kate/kde seems, acts like all others editors of Slack 12.2, so this is a try to clarify direction. ps.: Sorry for my broken en. Vit

[mc-butler]

Changed by vit_r (vit_r@….ru) on Mar 29, 2009 at 16:39 UTC (comment 4.6)

• Type changed from enhancement to defect

Replying to angel_il:

for test:
select text trought F3 with arrows.
move cursor another position.
press F5.
Text inserted but cursor not after pasted text.

Please rework.

place_curs2.diff attached 2009-03-29 20

[mc-butler]

Changed by vit_r (vit_r@….ru) on Mar 29, 2009 at 16:42 UTC (comment 5.7)

Replying to ossi:

i'm not positive about the idea as such.
most editors advance the cursor when pasting, and it generally makes sense. however, i often find mcedit's non-advancing behavior advantageous as well.

kate/kdevelop solve this problem by overloading the vertical block selection mode switch with also doing non-advancing insertions. obviously, this is not applicable to mcedit, as no vertical selection mode is planned, only vertical selection actions.

the new qt creator ide has a different approach: insertions do advance the cursor, but if you change the line afterwards without doing something else in between, the column is reset to the pre-insertion one - you get optimal behavior for both "flowed" and "blocked" operations.

place_curs2.diff attached 2009-03-29 20
my kate/kde seems, acts like all others editors of Slack 12.2,
so this is a try to clarify direction.

ps
Sorry for my broken en.

Vit

[mc-butler]

Changed by ossi (@ossilator) on Mar 29, 2009 at 19:42 UTC (comment 8)

kate behaves as i said. you just did not enable the vertical selection mode i talked about. ctrl-shift-b and things look different.

ps: http://www.netmeister.org/news/learn2quote.html

[mc-butler]

Changed by Vit R on Mar 30, 2009 at 6:08 UTC

ossi, thanks !

Right: kate acts either one or another way.

But your idea attracts me

And i'm going to add keys Up, PageUp, etc

Vit

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 30, 2009 at 9:08 UTC (comment 7.10)

Replying to vit_r:

Replying to ossi:

i'm not positive about the idea as such.

I think it there should be optional, for example an option: [x] cursor after inserted text.

obviously, this is not applicable to mcedit, as no vertical selection mode is planned, only vertical selection actions.

hmm... Shift+F3 ?!

[mc-butler]

Changed by ossi (@ossilator) on Mar 30, 2009 at 9:56 UTC (comment 11)

@Ilia: ahhh, even more option-mania. ;)
an option does not help - having to go to the options dialog to change the mode makes it virtually useless. and having a hotkey for an option from the config dialog is just awkward.

shift-f3 is different from kate's vertical selection mode, as it is an exclusive mode with a very limited lifetime ("modal mode", heh). but one could still use that: if the copied selection is a block selection in the first place, then do a non-advancing insertion. this has two minor problems, though: a) even small selections within one line (which pose the majority for the purpose of copying something into multiple adjacent lines) need to be done as vertical selections and b) mc's clipboard does not know whether something comes from a vertical or flowed selection (shift-f5 insertions are always flowed). a) is a non-issue when the alt-shift-arrow selections are implemented (these are way easier to use than shift-f3) and b) is solvable via an extension of the clipboard format.

@vit: which idea do you mean? then one from qt creator? it certainly is the optimum ...

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 30, 2009 at 11:32 UTC (comment 11.12)

Replying to ossi:

@Ilia: ahhh, even more option-mania. ;)

no, it way to compatibility with old mc-users, nothin more :)

an option does not help - having to go to the options dialog to change the mode makes it virtually useless. and having a hotkey for an option from the config dialog is just awkward.

for this case i try make macros engine for bind no any hotkeys any macros.
For example in FAR you can bind macros like this:
"F4, F7, "ABC", Enter, CtrlShiftLeft, CtrlIns, Esc, ShiftF4, ShiftIns, Enter"
(open cur file, exec search dialog, type "ABC", do search, select one word to left, copy to clip, close editor, create new file, paste word from clipboard, press enter)

i make macros engine in mc like a FAR (experemental branch).

for example: i need swich on option "[ ] &Backspace through tabs" from maros and bind it on Alt-B (for example).
i'm put in ~/.mc/macros
macro1={edit_options_dialog}"B""\n"
(execute edit_options_dialog, press "B", press Enter)
and in file
~/.mc/hotkeys
i'm put
macro1=<my hotkey>

and anytime that i need change "Backspace through tabs" mode i press <my hotkey>

i hope have clearly described idea...