Skip to content

Conversation

@egmontkob
Copy link
Contributor

Proposed changes

F9 menu:

  • Remove the unused (and not Unicode compatible) first letter feature
  • Fix the amount of right padding
  • Fix horizontal mouse coordinates

Checklist

👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@github-actions github-actions bot added this to the Future Releases milestone Nov 25, 2025
@github-actions github-actions bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Nov 25, 2025
@egmontkob egmontkob modified the milestones: Future Releases, 4.8.34 Nov 25, 2025
@egmontkob egmontkob requested a review from mc-worker November 25, 2025 22:31
@egmontkob
Copy link
Contributor Author

Shall I maybe keep the "first letter" feature, just in case we wish to use it one day?

Making it Unicode compatible to show a tick symbol is as easy as changing an unsigned char to gunichar.

@mc-worker
Copy link
Contributor

Shall I maybe keep the "first letter" feature, just in case we wish to use it one day?

Yes, I think this feature should be kept, for example, to show menu item as checked/unchecked.

Signed-off-by: Egmont Koblinger <egmont@gmail.com>
Signed-off-by: Egmont Koblinger <egmont@gmail.com>
@egmontkob
Copy link
Contributor Author

Yes, I think this feature should be kept

Done.

@egmontkob egmontkob merged commit 9e9f67a into MidnightCommander:master Nov 28, 2025
10 checks passed
@egmontkob egmontkob deleted the 4911-menu-padding branch November 28, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Needs triage by maintainers prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

Uneven padding in menus

2 participants