Skip to content

Conversation

@egmontkob
Copy link
Contributor

Recognize in nroff's output if bold typeface and underlining are applied simultaneously. Introduce a corresponding new skin file keyword.

Proposed changes

Checklist

👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

…pages

Recognize in nroff's output if bold typeface and underlining are applied
simultaneously. Introduce a corresponding new skin file keyword.

Signed-off-by: Egmont Koblinger <egmont@gmail.com>
@github-actions github-actions bot added the needs triage Needs triage by maintainers label Jan 2, 2026
@egmontkob egmontkob added this to the 4.8.34 milestone Jan 2, 2026
@github-actions github-actions bot added the prio: medium Has the potential to affect progress label Jan 2, 2026
@github-actions github-actions bot added this to the Future Releases milestone Jan 2, 2026
@egmontkob egmontkob requested review from mc-worker and zyv January 2, 2026 11:52
@egmontkob
Copy link
Contributor Author

I created this patch 10 years ago, and updated it now. Let's land it finally :)

@zyv zyv added area: mcview mcview, the built-in text editor and removed needs triage Needs triage by maintainers labels Jan 2, 2026
@zyv zyv modified the milestones: Future Releases, 4.8.34 Jan 2, 2026
@egmontkob egmontkob merged commit 885426a into MidnightCommander:master Jan 5, 2026
12 checks passed
@egmontkob egmontkob deleted the 3531-nroff-bold-underlined branch January 5, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: mcview mcview, the built-in text editor prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

roff underline+bold not recognized

3 participants