Skip to content

Add more Debian extensions to filehighlight.ini#5109

Merged
zyv merged 2 commits intoMidnightCommander:masterfrom
sergey-dryabzhinsky:add-more-debian-ext-to-file-highlight
May 9, 2026
Merged

Add more Debian extensions to filehighlight.ini#5109
zyv merged 2 commits intoMidnightCommander:masterfrom
sergey-dryabzhinsky:add-more-debian-ext-to-file-highlight

Conversation

@sergey-dryabzhinsky
Copy link
Copy Markdown
Contributor

@sergey-dryabzhinsky sergey-dryabzhinsky commented Apr 28, 2026

Proposed changes

Add mode debian file extensions

  • ddeb
  • udeb

Checklist

👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@github-actions github-actions Bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Apr 28, 2026
@github-actions github-actions Bot added this to the Future Releases milestone Apr 28, 2026
@zyv zyv added area: core Issues not related to a specific subsystem and removed needs triage Needs triage by maintainers labels Apr 28, 2026
@zyv
Copy link
Copy Markdown
Member

zyv commented Apr 28, 2026

@mc-worker, apparently on the latest Fedora they redefined strchr as const char * also for C, not only for C++. But the code itself is quite disgusting in that it modifies original strings through derived pointers. Could you please help to rewrite it in some clear and simple way without stripping qualifiers to fix the CI?

path.c: In function 'vfs_path_from_str_deprecated_parser':
path.c:360:20: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  360 |         url_params = strchr (op, ':');  // skip VFS prefix

@mc-worker
Copy link
Copy Markdown
Contributor

apparently on the latest Fedora they redefined strchr as const char * also for C, not only for C++.

This is C23. I read about that in the Gnulib mailing list:
https://lists.gnu.org/archive/html/bug-gnulib/2025-11/msg00220.html.

Could you please help to rewrite it in some clear and simple way without stripping qualifiers to fix the CI?

I have a cleanup branch with few commits. I'll make it there.

@zyv
Copy link
Copy Markdown
Member

zyv commented May 9, 2026

/rebase

@mc-butler mc-butler force-pushed the add-more-debian-ext-to-file-highlight branch from b3a4225 to 144a584 Compare May 9, 2026 13:52
…filehighlight.ini

Signed-off-by: Sergey Dryabzhinsky <sergey.dryabzhinsky+github@gmail.com>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
Signed-off-by: Sergey Dryabzhinsky <sergey.dryabzhinsky+github@gmail.com>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
@zyv zyv force-pushed the add-more-debian-ext-to-file-highlight branch from 144a584 to 43d71ce Compare May 9, 2026 14:09
@zyv zyv changed the title Add more debian ext to file highlight Add more Debian extensions to file highlight May 9, 2026
@zyv zyv changed the title Add more Debian extensions to file highlight Add more Debian extensions to filehighlight.ini May 9, 2026
@zyv zyv merged commit 4067aa4 into MidnightCommander:master May 9, 2026
10 checks passed
@zyv
Copy link
Copy Markdown
Member

zyv commented May 9, 2026

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

Add more debian file extensions to file highlights

3 participants