Skip to content

skins: add Tokyo Night truecolor skin#5114

Merged
zyv merged 1 commit intoMidnightCommander:masterfrom
eugenefvdm:tokyo-night-skin
May 9, 2026
Merged

skins: add Tokyo Night truecolor skin#5114
zyv merged 1 commit intoMidnightCommander:masterfrom
eugenefvdm:tokyo-night-skin

Conversation

@eugenefvdm
Copy link
Copy Markdown
Contributor

Summary

Adds a Tokyo Night skin for Midnight Commander using truecolor (#rrggbb) values.

Tokyo Night is a widely-used dark color scheme originally created by enkia for VS Code. It has since been ported to many editors and terminal tools. This skin brings the same palette to mc.

Color palette used

Role Color
Background #1a1b26
Foreground #a9b1d6
Accent blue #7aa2f7
Accent cyan #0db9d7
Yellow #e0af68
Green #9ece6a
Red #f7768e
Purple #bb9af7
Comment #444b6a

Requirements

A truecolor-capable terminal emulator. The skin sets truecolors = true in its [skin] header per the convention described in misc/skins/README.txt.

Test plan

  • Load skin with mc -S tokyo-night-16M
  • Verify panels, dialogs, editor, viewer and diffviewer all render correctly
  • Confirm on a non-truecolor terminal that mc falls back gracefully

@github-actions github-actions Bot added this to the Future Releases milestone May 5, 2026
@github-actions github-actions Bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels May 5, 2026
@zyv
Copy link
Copy Markdown
Member

zyv commented May 5, 2026

I checked the skin in the skin editor and I find it very weird that it doesn't have any borders. I've had a look at the linked repository and I think that nothing in this style precludes traditional borders of mc, as the gutters, tab separators and such in VS Code are clearly visible. Could you please adjust that?

Also, on a technical note, please use color aliases like in the other 16M skins. You made a table for the PR description, which is nice. However, it's impossible to decode the hex values in the head when looking at the file, which makes the skin unmaintainable.

Finally, for some reason, hardlink isn't styled.

@zyv zyv requested a review from egmontkob May 5, 2026 13:40
@zyv zyv added area: skin Theming support and skin files and removed needs triage Needs triage by maintainers labels May 5, 2026
@zyv
Copy link
Copy Markdown
Member

zyv commented May 5, 2026

I checked the skin in the skin editor and I find it very weird that it doesn't have any borders. I've had a look at the linked repository and I think that nothing in this style precludes traditional borders of mc, as the gutters, tab separators and such in VS Code are clearly visible. Could you please adjust that?

Oh, I understand why the lines are missing (in the skin editor). You fall back on the default lines. Please complete the sections [lines] and [widget-*], for example, from other 256 or 16M skins.

In general, I think the colors are pretty well chosen, especially compared to the previous submission.

Screenshot 2026-05-05 at 15 47 04

The only part that bothers me is the toxic / acidic error message dialog. Could you please adjust this?

Screenshot 2026-05-05 at 15 46 57

@egmontkob egmontkob removed their request for review May 5, 2026 14:14
@eugenefvdm
Copy link
Copy Markdown
Contributor Author

eugenefvdm commented May 8, 2026

Hi there @zyv,

Thank you so much for your feedback. Please have a look now:

image image

Copy link
Copy Markdown
Member

@zyv zyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm of the opinion that it now looks really nice, both technically and artistically! Finally, our first user-contributed 16M skin 🎉

The only thing to do now, I think, is you have forgotten to add it to Makefile.am, so it won't actually get shipped and installed otherwise.

I'll merge this as soon as master gets unblocked.

Tokyo Night is a popular dark color scheme originally created by enkia for VS
Code. This skin brings the same palette to Midnight Commander using truecolor
(#rrggbb) values.

Requires a truecolor-capable terminal (truecolors = true is already specified
in the [skin] header).

Signed-off-by: Eugene van der Merwe <eugenevdm@gmail.com>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
@zyv zyv force-pushed the tokyo-night-skin branch from ba203a4 to e559fe6 Compare May 9, 2026 14:40
@zyv zyv merged commit 7154215 into MidnightCommander:master May 9, 2026
10 checks passed
@zyv
Copy link
Copy Markdown
Member

zyv commented May 9, 2026

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: skin Theming support and skin files prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

2 participants