Skip to content

Conversation

@crogel23
Copy link
Contributor

When deleting a document, the expected response is a json, but tha API answers with a status code of 205 and an empty response.

This pull request adapts the client for the API response

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.053% when pulling c809f92 on cornershop:fix/delete-document into 02d81d0 on Mifiel:develop.

@coveralls
Copy link

coveralls commented Oct 15, 2019

Coverage Status

Coverage decreased (-0.1%) to 97.942% when pulling 4b3aec1 on cornershop:fix/delete-document into 02d81d0 on Mifiel:develop.

@joekohlsdorf
Copy link

@genaromadrid Any chance to get this merged and released?

@genaromadrid
Copy link
Member

Hey @joekohlsdorf sure.
@crogel23 thanks for the PR, we'll make changes to the other api clients as well to match this behavior.

@genaromadrid genaromadrid merged commit 9fd86ff into Mifiel:develop Jan 17, 2020
@genaromadrid
Copy link
Member

@joekohlsdorf the package has been released with the tag 0.0.7, happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants