fix: modify KNN to also explore boundaries that do not contain the query point#1
Open
fix: modify KNN to also explore boundaries that do not contain the query point#1
Conversation
Migorithm
reviewed
May 18, 2024
| pub latitude: NonNanFloat, | ||
| } | ||
|
|
||
| pub trait TCoordianteFloat { |
Owner
There was a problem hiding this comment.
conversion logic is already implemented for f64. Perhaps, Trait is not necessary?
Collaborator
Author
There was a problem hiding this comment.
I just wanted to limit the types it can take.
Migorithm
reviewed
May 18, 2024
| self.search(&mut nearest_neighbors, query_point, k); | ||
|
|
||
| nearest_neighbors | ||
| .into_sorted_vec() |
Owner
There was a problem hiding this comment.
what would the cost of into_sorted_vec like?
Collaborator
Author
There was a problem hiding this comment.
Considering the use case, it seems unlikely that we will need to use a large value for 'k'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve the issue where the K-Nearest Neighbors algorithm cannot find points that are outside of the boundary to which it belongs.