Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the two things that weren't compiling for .90... and now it's compiling for .90.
I implemented IPartCostModifier.GetModuleCost(float defaultCost). I just made it do the same thing as GetModuleCost () . I didn't flip through the rest of the plugin to make sure this was the desired behavior... so I didn't delete the original GetModuleCost... because it's best not to throw parts out of the car until you know what they do. But it does compile and a quick test with the A.S.E.T rover shows that all the pieces of your plugin that mod uses are working... so that's promising. I put a test binary up at
https://www.dropbox.com/s/dhwtxhpaaw0mo1k/JSIPartUtilities.dll?dl=0
and put that link in both your thread on the plugin, and the A.S.E.T rover's thread, so you might wait a day or two on a merge, in case someone reports bugs?