Skip to content

[JitDiff X64] [EgorBo] Remove unsafe code from StringParser #1820

@MihuBot

Description

@MihuBot

Job completed in 3 minutes 7 seconds (remote runner delay: 0 seconds).
dotnet/runtime#125640

Main commit: dotnet/runtime@9e58389
PR commit: EgorBo/runtime-1@a74125c

Diffs

Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45394156
Total bytes of diff: 45394295
Total bytes of delta: 139 (0.00 % of base)
Total relative delta: 0.73
    diff is a regression.
    relative diff is a regression.


Top file regressions (bytes):
          83 : System.Diagnostics.Process.dasm (0.08 % of base)
          56 : System.Net.NetworkInformation.dasm (0.10 % of base)

2 total files with Code Size differences (0 improved, 2 regressed), 258 unchanged.

Top method regressions (bytes):
          29 (14.22 % of base) : System.Diagnostics.Process.dasm - System.IO.StringParser:ParseNextInt64():long:this (FullOpts)
          29 (14.22 % of base) : System.Net.NetworkInformation.dasm - System.IO.StringParser:ParseNextInt64():long:this (FullOpts)
          27 (13.57 % of base) : System.Diagnostics.Process.dasm - System.IO.StringParser:ParseNextInt32():int:this (FullOpts)
          27 (13.57 % of base) : System.Net.NetworkInformation.dasm - System.IO.StringParser:ParseNextInt32():int:this (FullOpts)
          27 (17.65 % of base) : System.Diagnostics.Process.dasm - System.IO.StringParser:ParseNextUInt64():ulong:this (FullOpts)

Top method regressions (percentages):
          27 (17.65 % of base) : System.Diagnostics.Process.dasm - System.IO.StringParser:ParseNextUInt64():ulong:this (FullOpts)
          29 (14.22 % of base) : System.Diagnostics.Process.dasm - System.IO.StringParser:ParseNextInt64():long:this (FullOpts)
          29 (14.22 % of base) : System.Net.NetworkInformation.dasm - System.IO.StringParser:ParseNextInt64():long:this (FullOpts)
          27 (13.57 % of base) : System.Diagnostics.Process.dasm - System.IO.StringParser:ParseNextInt32():int:this (FullOpts)
          27 (13.57 % of base) : System.Net.NetworkInformation.dasm - System.IO.StringParser:ParseNextInt32():int:this (FullOpts)

5 total methods with Code Size differences (0 improved, 5 regressed), 284690 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions