Fix: popup window blocks touches when tapOutsideToDismissPopup is false#206
Open
yaro-zakh wants to merge 1 commit intoMijick:mainfrom
Open
Fix: popup window blocks touches when tapOutsideToDismissPopup is false#206yaro-zakh wants to merge 1 commit intoMijick:mainfrom
yaro-zakh wants to merge 1 commit intoMijick:mainfrom
Conversation
When using PopupSceneDelegate, the popup UIWindow intercepts all touches even when the overlay is clear and tapOutsideToDismissPopup is disabled. This happens because SwiftUI layout containers (GeometryReader, ZStack) create full-screen UIKit backing views that are found by hitTest, causing the window to claim touches meant for the main app window. Changes: - Window hitTest methods (iOS 17/18/26) now check for gesture recognizers when tapOutsideToDismissPopup is false. Only touches on views with gesture recognizers (actual popup content) are captured; touches on empty container views pass through to the underlying window. - Overlay view has .allowsHitTesting(tapOutsideClosesPopup) so it does not create a hit-testable UIKit view when it should not capture touches. This allows toast-style popups (TopPopup with clear overlay and tapOutsideToDismissPopup(false)) to display without blocking user interaction with the app content behind them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Test plan