ci: run workflows on pull_request, restrict push to main#45
Merged
Conversation
Previously every CI workflow (Test, Coverage, Credo, Dialyzer) ran on
'on: push', which fired for both branch pushes and PR sync events,
duplicating runs. Switch to:
on:
push:
branches: [main]
pull_request:
This runs CI once per PR update (and once on main after merge) instead
of twice for every PR push.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 83.46% 83.46% -0.01%
==========================================
Files 22 22
Lines 617 635 +18
==========================================
+ Hits 515 530 +15
- Misses 102 105 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test,Coverage,Credo,Dialyzer) usedon: push, which fires on every branch push and on PR sync events — every PR update kicked off two duplicate runs.mainafter merge (covering post-squash branch protection / status checks).Test plan
pull_requesttrigger and report Test / Coverage / Credo / Dialyzer once each.main, those four checks fire again onmainvia thepush: branches: [main]trigger.