Update .npmrc and build:cf script for better cross-platform compatibi…#5
Update .npmrc and build:cf script for better cross-platform compatibi…#5MikePfunk28 merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves cross-platform compatibility by updating npm configuration and build scripts to handle optional dependencies more consistently. The changes focus on avoiding platform-specific package installation issues.
- Removes
--no-optionalflag from thebuild:cfscript in package.json - Updates
.npmrcto explicitly disable optional dependencies and set platform to linux
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Simplified build:cf script by removing --no-optional flag |
| .npmrc | Added explicit optional=false and platform=linux settings with improved comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # This will help avoid installing incompatible packages | ||
| platform=linux No newline at end of file |
There was a problem hiding this comment.
Hardcoding platform=linux may cause issues for developers working on other platforms (Windows, macOS). Consider using a more flexible approach or documenting this requirement clearly.
| # This will help avoid installing incompatible packages | |
| platform=linux | |
| # (If your project requires a specific platform, document this in the README instead of hardcoding it here.) |
| "dev:backend": "convex dev", | ||
| "build": "vite build", | ||
| "build:cf": "npm install --no-optional && vite build", | ||
| "build:cf": "npm install && vite build", |
There was a problem hiding this comment.
The change from 'npm install --no-optional' to 'npm install' contradicts the .npmrc setting of 'optional=false'. This creates inconsistency between the two approaches to handling optional dependencies.
| "build:cf": "npm install && vite build", | |
| "build:cf": "npm install --no-optional && vite build", |
Deploying agent-builder-application with
|
| Latest commit: |
0943c37
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8d07126b.agent-builder-application.pages.dev |
| Branch Preview URL: | https://test.agent-builder-application.pages.dev |
…lity