Snark Worker: Remove Prod.single_spec #17274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
force-pushed
the
corvo/remove-snark-worker-prod-single-spec
branch
from
a06d138 to
3bda605
Compare
Member
Author
|
!ci-build-me |
Member
I'd support that. I considered doing it as well. It will affect some internal tooling, but unlikely to impede anyone's workflow. |
glyh
added
the
snark-worker-optim
georgeee
approved these changes
May 29, 2025
Member
|
!ci-bypass-changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would conflict with #17275, but conflicts are not terribly hard to resolve.
This type is just
Snark_work_lib.Spec.Single(orSnark_work_lib.Selector.Single.Spec). Redundant.A general question: Is there any point supporting both yojson & sexp as debugging dump format? Could we get rid of sexp?