Snark Work Lib: Drop spec in partitioned result #17277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternal of single spec
…oned result with unit
glyh
changed the title
Member
Author
|
!ci-build-me |
glyh
added
the
snark-worker-optim
georgeee
approved these changes
May 29, 2025
| , Ledger_proof.Cached.t | ||
| , Sub_zkapp_spec.t | ||
| ( unit | ||
| , unit |
Member
There was a problem hiding this comment.
I wonder, is it useful to have a version of this type with Ledger_proof.Cached.t?
Maybe we could just use Ledger_proof.t? It looks like this structure is scoped to a particular context, and it doesn't feel like we'll need cached proofs in that context.
We don't need to cache subzkapp proofs, I think. They are shortlived.
Member
Author
There was a problem hiding this comment.
Indeed. I'll do that in next PR
Member
|
!ci-bypass-changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only type that would be passed across the network when snark worker returns. So I'll only remove spec in this. for other result it would be needed to still have spec in them so we can send them to network pool to further process.
Indeed stable types in those results need to go, will follow up in next PRs.