Test Mock Snark Work Coordinater: set up module, and Dumped_spec type #17292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!ci-build-me |
glyh
added
the
snark-worker-optim
georgeee
requested changes
Jun 2, 2025
| @@ -0,0 +1,7 @@ | |||
| type t = | |||
Member
There was a problem hiding this comment.
This test file makes no sense to me
Normally test pragma defines a test executable, here we define an executable that defines a type but does nothing.
Will an implementation of the test appear here later? Maybe then it makes sense to implement the test and push the type together with the implementation?
Or should it be a (library) pragma in dune file?
Member
Author
There was a problem hiding this comment.
I would later add real test here. This is blocked by Work Partitioner PRs
Member
There was a problem hiding this comment.
Could we hold merging it now, and update it later, when the necessary Work Partitioner PRs will land the compatible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Nothing fancy here. This is part of project Snark Worker Rework