Skip to content

Conversation

@Geometer1729
Copy link
Contributor

Explain your changes:

  • Fix a strange issue with nondeterminism in the proof cache regeneration
  • Move the script to regenerate it from src/lib/transaction_snark/README.md to scripts/regenerate-proof-cache.sh for ease of use.

Explain how you tested your changes:

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@Geometer1729
Copy link
Contributor Author

!ci-build-me

@Geometer1729
Copy link
Contributor Author

!ci-bypass-changelog

@Geometer1729
Copy link
Contributor Author

!ci-build-me

@georgeee
Copy link
Member

!ci-bypass-changelog

1 similar comment
@Geometer1729
Copy link
Contributor Author

!ci-bypass-changelog

@Geometer1729 Geometer1729 requested a review from georgeee May 30, 2025 18:14
@Geometer1729 Geometer1729 marked this pull request as ready for review May 30, 2025 19:28
@Geometer1729 Geometer1729 requested review from a team as code owners May 30, 2025 19:28
@Geometer1729
Copy link
Contributor Author

!ci-build-me

Copy link
Member

@georgeee georgeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some NITs

Geometer1729 and others added 5 commits June 2, 2025 08:50
Co-authored-by: George Agapov <george.agapov@gmail.com>
Co-authored-by: George Agapov <george.agapov@gmail.com>
Co-authored-by: George Agapov <george.agapov@gmail.com>
Co-authored-by: George Agapov <george.agapov@gmail.com>
@Geometer1729
Copy link
Contributor Author

!ci-build-me

@Geometer1729 Geometer1729 merged commit 49bdeb4 into compatible Jun 2, 2025
51 checks passed
@Geometer1729 Geometer1729 deleted the brian/proof-cache branch June 2, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants