fix(premium): remove buy-credits command and add test case for PREMIUM-004 (Vibe Kanban)#6
Conversation
Update ground truth from 'minara premium buy-credits' to 'minara premium buy-credits -a 100' to include the amount parameter extracted from the user's query "购买 100 credits 的充值包". Note: Tests will fail until CLI adds -a/--amount option to buy-credits command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add non-interactive options for buy-credits command: - -a, --amount <number>: Specify package price (e.g., 10, 20, 50) - -p, --pay <method>: Specify payment method (stripe or crypto) Allows users to skip interactive prompts when amount and payment method are known, enabling automation and scriptable workflows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MinaraAgent
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new test case for purchasing credit packages via the CLI, but the accompanying code changes incorrectly delete the buy-credits command and its associated CreditPackage type instead of updating them. The feedback highlights that the command should be restored and modified to support the -a/--amount flag for non-interactive use as specified in the test case notes.
I am having trouble creating individual review comments. Click here to see my feedback.
src/commands/premium.ts (334-415)
The buy-credits command implementation has been entirely deleted. According to the pull request description and the notes in the new test case (minara-skill-test-cases.json), this command should be updated to support an -a/--amount option for non-interactive use, rather than being removed. This deletion is a critical regression that will break existing functionality and cause the PREMIUM-004 test case to fail. Please restore the command and implement the requested option.
src/commands/premium.ts (10)
The CreditPackage type import was removed. This type is necessary for the buy-credits command logic. Please restore this import when the command is restored.
Remove the buy-credits feature from premium command as per user request. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MinaraAgent
force-pushed
the
vk/fcb7-min-3-fix-premiu
branch
from
cbdac0d to
045c047
Compare
2 participants
Summary
buy-creditscommand from the premium moduleminara-skill-test-cases.jsonwith PREMIUM-004 ground truthChanges
Premium Command
minara premium buy-creditssubcommand entirelyCreditPackagetype import (no longer needed)Test Data
minara-skill-test-cases.jsonwith PREMIUM-004 test caseminara premium buy-credits -a 100(for "购买 100 credits 的充值包")Why
The
buy-creditsfeature was removed as it should not be exposed as a CLI command. The test case file was added to document the expected behavior for the skill routing system, even though the underlying CLI command has been removed.This PR was written using Vibe Kanban