This repository was archived by the owner on Oct 6, 2020. It is now read-only.
Try to parse into a known error on fail.#248
Merged
MindFlavor merged 1 commit intoMindFlavor:masterfrom Mar 23, 2020
Merged
Conversation
Get the body text and try to parse into a login response. If that fails try to parse the body to get an `error_description` from Azure. If that fails report whatever the original issue was with parsing as the error. `ErrorResponse` could be expanded on to recognize the `error` field and give more useful info. Not sure what connecting `ErrorResponse` to `AzureError` in a nice way looks like, but this leaves all the interfaces the same for now.
Contributor
Author
|
The goal of this btw is to have better error messages. Right now if you |
Owner
|
Nice! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get the body text and try to parse into a login response.
If that fails try to parse the body to get an
error_descriptionfromAzure. If that fails report whatever the original issue was with parsing
the response as the error.
ErrorResponsecould be expanded on to recognize theerrorfield andgive more useful info. Not sure what connecting
ErrorResponsetoAzureErrorin a nice way looks like, but this leaves all theinterfaces the same for now.