This repository was archived by the owner on Oct 6, 2020. It is now read-only.
Improve macros#256
Merged
MindFlavor merged 2 commits intoMindFlavor:masterfrom Apr 19, 2020
kichristensen:ImproveMacros
Merged
Conversation
This ensures that users don't get any suprises when using the macro. Previously users would would have to import several different types fron std and from the crate. With this change this is no longer necessary
Fully qualify imports in the macro, to ensure no imports are needed when using it
MindFlavor
added
Blob storage
Owner
|
Thank you very much! I'll publish them ASAP! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully qualify imports in the macro, to ensure no imports are needed when using it.
Previously users would get surprises when using the macro, as it would fail to compile if the right imports weren't defined.