refactor: centralize routing and eliminate duplicate sources#108
Open
Nacho1499 wants to merge 6 commits into
Open
refactor: centralize routing and eliminate duplicate sources#108Nacho1499 wants to merge 6 commits into
Nacho1499 wants to merge 6 commits into
Conversation
|
@Nacho1499 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
conflict resolved |
Contributor
|
@Nacho1499 please resolve conflict |
Contributor
Author
|
conflict resolved boss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79
PR Description:
This PR addresses issue #79 by eliminating duplicate routing sources between the main application engine and the routing metadata configurations. All runtime paths, layout components, and navbar hooks have been consolidated into a single absolute source of truth.
Changes Made:
**Unified Configuration: Created as the single source of truth for all routes. Brought the static sub-section assembly and the fallback components inside it.src/config/routes.tsxHomeNotFound.
**Safe Lazy Loading: Implemented robust type-safe wrapper modules capable of handling both named and default component file exports flawlessly.lazy().
**Streamlined App.tsx: Removed all hardcoded or split route mapping configurations from . It now acts purely as a delivery engine that loops over dynamically inside .src/App.tsxrouteConfig
**Strict Type Alignment: Resolved compile-time errors regarding type imports () and removed local JSX parser errors by shifting the configurations into a clean format.verbatimModuleSyntax.tsx.
Verification Checklist:
[x] Only one route definition source is used at runtime.
[x] Both the layout page routing () and header navigation arrays () derive data from the same exact configuration set.src/App.tsxgetNavItems.
[x] Breaking modifications/path changes in a single location can no longer trigger a desynchronization regression or accidental 404 errors.