Conversation
Collaborator
sanjay-mi
commented
May 16, 2023
sanjay-mi
commented
- ViewBinding implemented and Kotlin Synthetic removed
- Gradle version updated to 8.0.1
- Sorting functionality added
-Optimized the attributes
Enabled actual circular crop for oval shape
- Used ViewModelProvider constructor to build the ViewModel instead of ViewModelProviders
# Conflicts: # README.md # app/src/main/java/com/lassi/app/MainActivity.kt # lassi/build.gradle # lassi/src/main/java/com/lassi/domain/media/LassiConfig.kt # lassi/src/main/java/com/lassi/presentation/builder/Lassi.kt
# Conflicts: # README.md # build.gradle # lassi/build.gradle
Make single image selection cropping optional
* Latest Android 11 support - Gradle version updated to v4.1.3 instead of v4.1.1 - Kotlin version updated to v1.4.32 instead of v1.4.21 - Multidex added - CompileSdkVersion updated to android-S instead of 30 - buildToolVersion 30.0.3 added - ViewModelProviders code changes due to deprecation - request permission and start activity for result code changes in docsFragment and FolderFragment * PDF and other non media files not listing issue solved for Android 11 and 12 * Camera not working issue resolved and Camera permission changes applied * Android 10 Non media file choose from system file explorer feature implementation - Gradle version updated to v4.2.0 instead of 4.1.3 - Kotlin version updated to v1.5.0 instead of 1.4.32 * Lassi picker version updated to v0.2.0 instead of v0.1.7 * CompileSdkVersion changed to 30 instead of android-S due to APK file not installed issue - BuildToolVersion changed to v30.0.3 instead of v31.0.0 rc3 * Cropping image URI not working issue resolved
* Added file size limit restriction to display in grid (#22) * -Enabled actual circular crop -Optimized the attributes * Upgrade lib version and README.md * Updated dependencies versions, Minor changes in style (#18) - Used ViewModelProvider constructor to build the ViewModel instead of ViewModelProviders * Update library version and README.md * Added file size limit restriction to display in grid Co-authored-by: Bhoomi Shah <bhoomishah20495@gmail.com> Co-authored-by: AKASH PATEL <akash.mindinventory@gmail.com> Co-authored-by: milanvadhel-mi <73939866+milanvadhel-mi@users.noreply.github.com> * Optional crop (#23) Make single image selection cropping optional * Update library version and README.md * Update README.md * Latest Android 11 support [WIP] - Gradle version updated to v4.1.3 instead of v4.1.1 - Kotlin version updated to v1.4.32 instead of v1.4.21 - Multidex added - CompileSdkVersion updated to android-S instead of 30 - buildToolVersion 30.0.3 added - ViewModelProviders code changes due to deprecation - request permission and start activity for result code changes in docsFragment and FolderFragment * PDF and other non media files not listing issue solved for Android 11 and 12 * Camera not working issue resolved and Camera permission changes applied * Android 10 Non media file choose from system file explorer feature implementation - Gradle version updated to v4.2.0 instead of 4.1.3 - Kotlin version updated to v1.5.0 instead of 1.4.32 * Lassi picker version updated to v0.2.0 instead of v0.1.7 * CompileSdkVersion changed to 30 instead of android-S due to APK file not installed issue - BuildToolVersion changed to v30.0.3 instead of v31.0.0 rc3 * Cropping image URI not working issue resolved Co-authored-by: Malik Motani <mjmotani@gmail.com> Co-authored-by: Bhoomi Shah <bhoomishah20495@gmail.com> Co-authored-by: AKASH PATEL <akash.mindinventory@gmail.com> Co-authored-by: milanvadhel-mi <73939866+milanvadhel-mi@users.noreply.github.com> Co-authored-by: Faiyaz meghreji <50236417+faiyaz92@users.noreply.github.com>
# Conflicts: # app/build.gradle # app/src/main/java/com/lassi/app/MainActivity.kt # build.gradle # lassi/build.gradle # lassi/src/main/java/com/lassi/data/media/MiMedia.kt # lassi/src/main/java/com/lassi/presentation/camera/CameraFragment.kt # lassi/src/main/java/com/lassi/presentation/media/MediaFragment.kt
- Added selectionDrawable attribute option in xml - Updated UI - Updated library version and plugins - Updated README.md
… into develop � Conflicts: � README.md � app/src/main/java/com/lassi/app/MainActivity.kt � lassi/build.gradle
- target sdk version updated to 32
Hotfix/anr issue
* Develop (#52) - ANR issue was resolved. - Reject permission crash issue resolved. - Library version updated to 0.3.0 - Target SDK version updated, Android 12 support. * - System default view support given with defined view type - Min SDK version updated to 19 - Lassi version updated to v0.4.0 Co-authored-by: milanvadhel-mi <73939866+milanvadhel-mi@users.noreply.github.com> Co-authored-by: Chirag Prajapati <chirag.prajapati@mindinventory.com> Co-authored-by: Nkgohil007 <89060719+Nkgohil007@users.noreply.github.com> Co-authored-by: AKASH PATEL <akash.patel@mindinventory.com>
# Conflicts: # README.md # app/build.gradle # lassi/build.gradle
Co-authored-by: Akash Patel<akash.patel@mindinventory.com>
Feature/version
- Removed unnecessary provider from the manifest file of Lassi module
- Removed dcendents plugin
- Removed dcendents plugin - Code formatting and clean up
- Removed dcendents plugin - Code formatting and clean up
- Generated contract - Replaced ActivityForResult with ActivityResultContracts
- Generated contract - Replaced ActivityForResult with ActivityResultContracts - Modified cropper contract - Separated contract related data from LassiMediaPicker to CameraFrgment and MediaFragment - Handled video preview case - Code clean up
…ndroid13 Hotfix/runtime permission android13
…ource_linking_failed_#80 # Conflicts: # lassi/build.gradle # lassi/src/main/java/com/lassi/presentation/cameraview/controls/CameraView.java # lassi/src/main/java/com/lassi/presentation/cropper/CropImageView.java # lassi/src/main/java/com/lassi/presentation/mediadirectory/LassiMediaPickerActivity.kt # lassi/src/main/res/values/attrs.xml
…king_failed_#80 - Rebaptized Lassi attributes
…ailable_files_#74
…iles_#74 Hotfix/remove unavailable files #74
…t_fixes # Conflicts: # lassi/src/main/java/com/lassi/data/media/entity/MediaFileDao.kt # lassi/src/main/java/com/lassi/presentation/media/MediaFragment.kt
…merge from develop
…merge from develop - Resolved media sort issue
…merge from develop - Resolved media sort issue - Provided sort options for other media also
Hotfix/issue ticket fixes
Feature/viewbinding migration
# Conflicts: # app/build.gradle # app/src/main/java/com/lassi/app/MainActivity.kt # lassi/build.gradle # lassi/src/main/AndroidManifest.xml # lassi/src/main/java/com/lassi/presentation/camera/CameraFragment.kt # lassi/src/main/java/com/lassi/presentation/cameraview/controls/CameraView.java # lassi/src/main/java/com/lassi/presentation/mediadirectory/FolderFragment.kt
akashmi
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.