Skip to content

fix: Fixes in 1.0.0 release candidate #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miquelbeltran merged 3 commits into from
May 24, 2024
Merged

fix: Fixes in 1.0.0 release candidate #234

miquelbeltran merged 3 commits into from
May 24, 2024

Conversation

@miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented May 24, 2024

fix: Fixes in 1.0.0 release candidate

Description 📝

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Updates

  • Updated docs

Test plan 🧪

  • None

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran requested review from a team, PanosNB, TheRealAgentK and sumitramanga and removed request for a team May 24, 2024 05:33
PanosNB
PanosNB approved these changes May 24, 2024
View reviewed changes
Copy link

@PanosNB PanosNB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@miquelbeltran miquelbeltran merged commit f5c1307 into develop May 24, 2024
@miquelbeltran miquelbeltran deleted the fixes-1.0.0 branch May 24, 2024 06:01
miquelbeltran added a commit that referenced this pull request May 28, 2024
@miquelbeltran
fix: Fixes in 1.0.0 release candidate (#234)
1de561a 
* docs: update send params in README

* docs: add Breadcrumbs info

* docs: change should by must
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealAgentK TheRealAgentK Awaiting requested review from TheRealAgentK TheRealAgentK was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@sumitramanga sumitramanga Awaiting requested review from sumitramanga sumitramanga was automatically assigned from MindscapeHQ/kai-miquel-and-friends

1 more reviewer

@PanosNB PanosNB PanosNB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miquelbeltran @PanosNB