-
Notifications
You must be signed in to change notification settings - Fork 25
ci: GitHub setup #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: GitHub setup #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR primarily adds GitHub CI workflows for formatting, static analysis, and testing along with minor code reformatting changes across the codebase.
- Added CI workflow configurations, issue templates, and dependabot updates.
- Reformatted code to consistently use double quotes and adjusted whitespace/line-breaks for clarity.
- Updated various tests and middleware files with style improvements without changing core logic.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python3/tests/*.py | Updated tests formatting to use consistent quoting and style. |
| python3/raygun4py/**/*.py | Reformatted code to use double quotes and standardized code style. |
| .github/workflows/.yml & .github/ISSUE_TEMPLATE/.md | Added CI workflows, issue templates, and dependabot configuration. |
Comments suppressed due to low confidence (1)
python3/raygun4py/utilities.py:25
- Since you're iterating over each 'filter_key' in 'filtered_keys', consider checking for an exact match of the key (or moving the check outside the loop) to improve clarity and efficiency.
if key in filtered_keys:
.github/workflows/python-checks.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given 3.14 is coming not too far in the future - is there a way we can build against early 3.14 versions, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that specifying the exact version 3.14.0-alpha.7 works. I tried first with 3.14 and it didn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, we don't want to put something out that's not released/not ina stable working state :)
|
I think the PR itself is fine, it needs a new RG app api key for CI build purposes and we need to set up the secret and then builds should hopefully pass. @miquelbeltran can you create and do that? |
|
@TheRealAgentK I don't have permissions to access the repo settings and create a secret env variable. I will ask internally. |
|
The API key setup is now done, and the PR is ready for a final review |
sumitramanga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recent changes looks good 💯
Description 📝
Purpose:
Adds GitHub CI jobs to run on each PR, as well as other useful repo templates. Similar to what we do in the other projects.
Approach:
Copied and adapted ci jobs and templates from raygun4node.
CI job runs with all the currently stable python versions.
Type of change
fix:Bug fix (non-breaking change which fixes an issue)feat:New feature (non-breaking change which adds functionality)chore:Chore task, release or small impact changeci:CI configuration changeUpdates
RAYGUN_API_KEYinstead of hardcoded api key (this needs to be added to the project settings secrets)Not in this PR:
RAYGUN_API_KEYRelated issues
Test plan 🧪
Author to check 👓
Reviewer to check ✔️