Fix undefined Promise.prototype.finally when using promise rejection tracking#60
Merged
Callum-McKay merged 1 commit intomasterfrom May 18, 2022
Merged
Conversation
When tracking unhandled Promise rejections, we polyfill the Promise global. The `promise` polyfill module is split into a number of submodules, that implement different parts of the Promise specification. As we were only requiring es6-extensions, Promise.prototype.finally and Promise.prototype.done were not defined. We can fix this by requiring the done and finally implementations from the `promise` module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tracking unhandled Promise rejections, we polyfill the Promise global.
The
promisepolyfill module is split into a number of submodules, thatimplement different parts of the Promise specification.
As we were only requiring es6-extensions, Promise.prototype.finally and
Promise.prototype.done were not defined. We can fix this by requiring
the done and finally implementations from the
promisemodule.Fixes #42