Skip to content

Bug fix#77

Merged
redJ4y merged 4 commits intomasterfrom
js/update-gradle
Nov 27, 2023
Merged

Bug fix#77
redJ4y merged 4 commits intomasterfrom
js/update-gradle

Conversation

@redJ4y
Copy link
Contributor

@redJ4y redJ4y commented Nov 27, 2023

  • Update Android Gradle build tools plugin to 7.4.2.
    • Supports newer versions of Gradle and resolves some build warnings.
  • Revert Raygun4Apple upgrade (from 1.3.0-beta).
    • I don't trust that the Swift package will work seamlessly with the podspec in every situation. This can be re-investigated when a newer version of Raygun4Apple comes out that actually adds new features.
  • Move com.raygun.react namespace back to AndroidManifest.xml.
    • This seems to be the right thing to do!

@redJ4y redJ4y changed the title Js/update gradle Bug fix Nov 27, 2023
I still don't trust that the Swift package will always work smoothly in the podspec
@redJ4y redJ4y requested a review from sumitramanga November 27, 2023 03:25
@sumitramanga
Copy link
Collaborator

Can I please get some more context as to why these changes are needed (also good for anyone looking at this PR!) :)

Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@redJ4y redJ4y merged commit 1af417d into master Nov 27, 2023
@redJ4y redJ4y deleted the js/update-gradle branch November 27, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants