Skip to content

Upgrade Affected User Tracking#34

Merged
UberMouse merged 7 commits intomasterfrom
upgrade-affected-user-tracking
Mar 9, 2017
Merged

Upgrade Affected User Tracking#34
UberMouse merged 7 commits intomasterfrom
upgrade-affected-user-tracking

Conversation

@nikz
Copy link
Contributor

@nikz nikz commented Jul 18, 2014

Initial work on upgrading affected user tracking.

Ping @MindscapeHQ/ruby-team, @armstrjare, @NZKoz, @CmdrKeen for feedback :)

@NZKoz
Copy link

NZKoz commented Jul 19, 2014

Rather than this weird hash which maps properties, why not use a proc? Was:

config.affected_user_method_mapping.Email << :email_address 

Could be:

  config.affected_user do |something|
    {Email: something.email}
end

Proc could take controller, rack hash thingy, etc?

etc

@nikz
Copy link
Contributor Author

nikz commented Jul 19, 2014

Yeah, I'm actually leaning toward that... Because everyone is going to be
slightly different and the complexity of trying to make it magical seems to
outweigh the benefits.

On Saturday, July 19, 2014, Michael Koziarski notifications@github.com
wrote:

Rather than this weird hash which maps properties, why not use a proc? Was:

config.affected_user_method_mapping.Email << :email_address

Could be:

config.affected_user do |something|
{Email: something.email}end

Proc could take controller, rack hash thingy, etc?

etc


Reply to this email directly or view it on GitHub
#34 (comment)
.

@UberMouse UberMouse force-pushed the upgrade-affected-user-tracking branch from 1f2b20b to a68777c Compare March 9, 2017 00:40
@UberMouse UberMouse merged commit 19cd98e into master Mar 9, 2017
@UberMouse UberMouse deleted the upgrade-affected-user-tracking branch March 9, 2017 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants