cache UserCache #12
Merged
cache UserCache #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only 3 places where the
UserCacheis ever created,MinecraftClient#startIntegratedServer,MinecraftClient#joinWorldand the dedicated server main method which we can ignore.As long as AntiResourceReload uses the cache on both
startIntegratedServerandjoinWorld, no otherUserCacheinstance will ever be created.The
MinecraftServer.USER_CACHE_FILEfield is also only ever accessed from those 3 placesMinecraftServer.USER_CACHE_FILEis also the only mention of usercache as a string, so the file is never written to in any other way in Minecraft.There is 3 occurances of UserCache#save, two in UserCache itself which are fine, one in MinecraftDedicatedServer#setupServer which ARR won't be loaded on.