1.15.2+1.2.1 - attempt to fix stopWorkers deadlock #12
Conversation
…n when worker threads are stopped
The custom hash table based implementation was not sound. This might also fix a few issues with mod compatibility. Should still be faster than the vanilla implementation, and it will significantly reduce the amount of code we're maintaining.
|
Note: This commit added here recently fixes a client game freeze when joining a lan server with chunkumulator and the host increases/decreases render distance (confirmed by testing) Since it's a jellysquid commit from 3 years ago and it reduces the amount of code sodium is responsible for, it is almost definitely good stuff so no review needed for the stuff in that commit. |
DuncanRuns
left a comment
DuncanRuns
left a comment
There was a problem hiding this comment.
PR includes trustworthy jellysquid fixes. Game booted with jar and other mcsr mods on and is stable.
Regarding the attempt to fix deadlock, the comment's logic is sound and I think the worst case scenario is that the deadlock is replaced by another similar issue caused by the side effect of the skipping of the wait() (which logically shouldn't be a problem given the condition of the skip)
3 participants
No description provided.