Skip to content

Conversation

@PaintNinja
Copy link
Contributor

@PaintNinja PaintNinja commented Nov 24, 2025

Updates Gradle and the jSpecify enforcement parts of the build.

The new NullAway now does null analysis on JDK lib usages as well even though the JDK itself isn't annotated with jSpecify, they accomplish this through a new feature in javac 21.0.8+/22+ which basically patches in the right annotations to the JDK itself as part of analysis.

Gradle 9.x to come later, blocked on upgrading to GradleUtils 3 which I'd like Jonathing's help with at a later date, low priority.

@Jonathing
Copy link
Member

No need to worry about Gradle 9 for now, I'll take care of it on my own time soon.

Copy link
Member

@Jonathing Jonathing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build succeeded. Aside from ASM, these dependency bumps only affect the build.

@PaintNinja
Copy link
Contributor Author

ASM is only used for the benchmarks iirc

@Jonathing
Copy link
Member

Jonathing commented Nov 24, 2025

Oh yeah, you are right on that one. Ok, all good. Ship it. :shipit:

@PaintNinja PaintNinja merged commit 409eb28 into MinecraftForge:master Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants